Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear unrequired headers of boost lexical_cast #35220

Merged
merged 1 commit into from Sep 13, 2021

Conversation

Purva-Chaudhari
Copy link
Contributor

@Purva-Chaudhari Purva-Chaudhari commented Sep 9, 2021

PR description:

Clear unrequired headers of boost lexical_cast .
(and Code-format in MuonAnalysis/MomentumScaleCalibration/test/Macros/CompareRecoGenPt.C )

PR validation:

Compiled and passed runtests

if this PR is a backport:

@davidlange6 @vgvassilev

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35220/25173

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

A new Pull Request was created by @Purva-Chaudhari for master.

It involves the following packages:

  • GeneratorInterface/AMPTInterface (generators)
  • GeneratorInterface/HijingInterface (generators)
  • GeneratorInterface/Hydjet2Interface (generators)
  • GeneratorInterface/HydjetInterface (generators)
  • Geometry/CommonTopologies (geometry)
  • HLTriggerOffline/Egamma (dqm)
  • MuonAnalysis/MomentumScaleCalibration (analysis)
  • PhysicsTools/SelectorUtils (reconstruction)

@SiewYan, @andrius-k, @ianna, @Saptaparna, @alberto-sanchez, @santocch, @civanch, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @mkirsano, @kmaeshima, @rvenditti can you please review it and eventually sign? Thanks.
@mkirsano, @bsunanda, @rchatter, @alberto-sanchez, @JanFSchulte, @fabiocos, @VinInn, @missirol, @thomreis, @simonepigazzini, @mmusich, @argiro, @mtosi, @cbaus, @bellan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14b529/18466/summary.html
COMMIT: 63cbeb4
CMSSW: CMSSW_12_1_X_2021-09-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35220/18466/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Sep 11, 2021

+reconstruction

for #35220 63cbeb4

  • trivial: in reco : PhysicsTools/SelectorUtils/bin/testSelection_wplusjets.C has an unused include dropped
  • jenkins tests pass

@qliphy
Copy link
Contributor

qliphy commented Sep 13, 2021

@cms-sw/generators-l2 Do you have any comment?

@agrohsje
Copy link

+generators
looks good. thanks.

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@Purva-Chaudhari Purva-Chaudhari deleted the testbranch_lexical_cast10 branch September 17, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants