Configure HCAL FIR Filter Based on HcalTPChannelParameters #35222
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35222/25174
|
|
A new Pull Request was created by @JHiltbrand (Joshua Hiltbrand) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @rekovic, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35222/25175
|
|
@cmsbuild , please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be0582/18470/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Quite a lot of changes in From the quote above I understand that this is not expected, @JHiltbrand please comment |
Hi @tvami, |
|
@JHiltbrand Where we have hardcoded conditions. Please, look back to the second footnote in my e-mail of August 27. And when we'll come to PFA1' for Phase2 (we're not there yet, right? - just considering solely Run3 ) we'll revert it in hardcoded conditions, unless we'll move to DB conditions for Phase2 by then... |
|
Hello @abdoulline , Thank you for this, I will look into the hardcoded conditions to see that I can get no changes in the output for this Phase2 wf. |
|
Changes may come from added #35081 |
|
@cmsbuild , please test
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be0582/18602/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
|
Ok great, now only 140.53 fails, that's expected due to "The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline" |
|
+alca |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be0582/19156/summary.html Comparison SummarySummary:
|
|
+1 |
PR description:
The enabling of a new FIR filter for HCAL trigger primitive reconstruction (#31661) is now done via the use of
HcalTPChannelParametersconditions. Here, TT channels are used (specifically the value of theirauxi1parameter, the weight for the filter) to determine if the FIR filter should be used in HB and/or HE. The absence of TT channels in theHcalTPChannelParametersconditions OR a value of-1.0for theauxi1field is interpreted as to NOT use the new filter. These changes will mirror logic in online software that is used to determine if HCAL backend electronics should be configured to use the new FIR filter, thus giving equivalent behavior online and offline.PR validation:
By default, with no changes made to the
HcalTPChannelParameters, the default algorithm is used and no changes in trigger primitives are expected.