Cleanup Geant4 termination

[civanch]

PR description:

This PR address problem #35038. If a job crash too early not all Geant4 managers are created and Geant4 crash shadow real crash. This PR should not affect any WF.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

May be useful to backport to 12_0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35245/25219

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a42d13/18543/summary.html
COMMIT: 455c40a
CMSSW: CMSSW_12_1_X_2021-09-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35245/18543/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 8.08.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
• 7.37.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step1_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log
• 9.09.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

Expand to see more relval errors ...

• 25.0
• 1306.0
• 312.0
• 101.0
• 1330.0
• 10042.0
• 25202.0
• 10024.0
• 10224.0
• 11634.0
• 10824.0
• 12434.0
• 11634.912
• 11634.911
• 250202.181
• 23234.0
• 34634.0
• 34834.999
• 28234.0

RelVals-INPUT

• 12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2023PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log
• 11834.9911834.99_TTbar_14TeV+2021PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2021PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log
• 13034.9913034.99_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log

Expand to see more relval errors ...

• 250202.1
• 23434.999
• 34834.999
• 23434.99
• 23434.9921
• 250202.171
• 34834.9921
• 250202.181
• 250202.3
• 250202.5
• 250206.181

AddOn Tests

• hlt_mc_FakecmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Mon Sep 13 12:37:54 2021-date Mon Sep 13 12:32:06 2021 s - exit: 34304
• hlt_mc_Fake1cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Mon Sep 13 12:38:01 2021-date Mon Sep 13 12:32:07 2021 s - exit: 34304
• hlt_mc_Fake2cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Mon Sep 13 12:38:07 2021-date Mon Sep 13 12:32:12 2021 s - exit: 34304

Expand to see more addon errors ...

• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PRef

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35245/25224

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35245 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a42d13/18547/summary.html
COMMIT: be5e9e9
CMSSW: CMSSW_12_1_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35245/18547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000973
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[mrodozov]

tried the change with the ubsan IB, it fixes the runtime error

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1