Avoid race condition in PluginFactoryBase

[Dr15Jones]

PR description:

Use atomic form of entry into the tbb::concurrent_unordered_map to avoid getting an empty entry.
This was pointed to by the UBSAN test showing where a reference was using a nullptr address.

PR validation:

Code compiles. All framework unit tests pass.

[Dr15Jones]

From https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/slc7_amd64_gcc10/CMSSW_12_1_UBSAN_X_2021-09-22-1600/pyRelValMatrixLogs/run/11640.0_MinBias_14TeV+2021+MinBias_14TeV_pythia8_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step3_MinBias_14TeV+2021+MinBias_14TeV_pythia8_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

/data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/tbb/v2021.3.0-d08d4722ccbb5e1470ca0b76226c3cf7/include/oneapi/tbb/detail/_segment_table.h:524:23: runtime error: reference binding to null pointer of type 'struct value_type'
/data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/tbb/v2021.3.0-d08d4722ccbb5e1470ca0b76226c3cf7/include/oneapi/tbb/concurrent_vector.h:728:97: runtime error: reference binding to null pointer of type 'struct value_type'
/data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc10/external/tbb/v2021.3.0-d08d4722ccbb5e1470ca0b76226c3cf7/include/oneapi/tbb/concurrent_vector.h:723:70: runtime error: reference binding to null pointer of type 'const struct value_type'
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/8a9f7cd15d83de9af8b390bae4e6d7d1/opt/cmssw/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_1_UBSAN_X_2021-09-22-1600/src/FWCore/PluginManager/src/PluginFactoryBase.cc:84:49: runtime error: reference binding to null pointer of type 'const struct PluginMakerInfo'
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/8a9f7cd15d83de9af8b390bae4e6d7d1/opt/cmssw/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_1_UBSAN_X_2021-09-22-1600/src/FWCore/PluginManager/src/PluginFactoryBase.cc:85:30: runtime error: member access within null pointer of type 'const struct PluginMakerInfo'
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/8a9f7cd15d83de9af8b390bae4e6d7d1/opt/cmssw/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_1_UBSAN_X_2021-09-22-1600/src/FWCore/PluginManager/src/PluginFactoryBase.cc:85:20: runtime error: member access within null pointer of type 'const struct PluginMakerInfo'

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35388/25485

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/PluginManager (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1494bb/18870/summary.html
COMMIT: d616869
CMSSW: CMSSW_12_1_X_2021-09-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35388/18870/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Migrating away from deprecated edm::EDAnalyzer API in CalibTracker/SiStripLorentzAngle #35381
• @mmusich simplify logic for AndOr in DetStatus #35378
• @francescobrivio Add logic in OnlineBeamSpotESProducer #35333
• @CMSTrackerDPG Migrating away from deprecated edm::EDAnalyzer API in CalibTracker/SiPixelESProducers #35375

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1494bb/18870/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1494bb/18870/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1