Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string when HiMixNoPU is used in relvals #35394

Merged
merged 1 commit into from Sep 24, 2021

Conversation

srimanob
Copy link
Contributor

PR description:

When HiMixNoPU workflow is used (e.g. 159.3), --pileup HiMixNoPU is used with cmsDriver. In this case, we don't expect PU_ in the processing string. This PR introduces the protection on that.

PR validation:

Test with runTheMatrix.py --what standard -l 159.3 --wm init

Before

 'Task2': {'AcquisitionEra': 'CMSSW_12_1_X_2021-09-23-2300',
           'ConfigCacheID': 1043,
           'EventStreams': 0,
           'GPUParams': None,
           'GlobalTag': '121X_mcRun3_2021_realistic_HI_v5',
           'InputFromOutputModule': 'RAWSIMoutput',
           'InputTask': 'ZMM_14_HI_2021',
           'KeepOutput': True,
           'LumisPerJob': 10,
           'Memory': 3000,
           'Multicore': 1,
           'ProcessingString': 'PU_121X_mcRun3_2021_realistic_HI_v5',
           'RequiresGPU': None,
           'SplittingAlgo': 'LumiBased',
           'TaskName': 'DIGIHI2021PPRECO'},

After

'Task2': {'AcquisitionEra': 'CMSSW_12_1_X_2021-09-23-2300',
           'ConfigCacheID': 1043,
           'EventStreams': 0,
           'GPUParams': None,
           'GlobalTag': '121X_mcRun3_2021_realistic_HI_v5',
           'InputFromOutputModule': 'RAWSIMoutput',
           'InputTask': 'ZMM_14_HI_2021',
           'KeepOutput': True,
           'LumisPerJob': 10,
           'Memory': 3000,
           'Multicore': 1,
           'ProcessingString': '121X_mcRun3_2021_realistic_HI_v5',
           'RequiresGPU': None,
           'SplittingAlgo': 'LumiBased',
           'TaskName': 'DIGIHI2021PPRECO'},

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no need of backport.

FYI @justinasr

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35394/25502

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@bbilin
Copy link
Contributor

bbilin commented Sep 24, 2021

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb8f00/18883/summary.html
COMMIT: bea21cf
CMSSW: CMSSW_12_1_X_2021-09-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35394/18883/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3211046
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

+Upgrade

Technical PR to assign workflow name properly. No change in Physics.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Technical

@cmsbuild cmsbuild merged commit 3ca3e8a into cms-sw:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants