Beamspot DIP server (normal DQM client)

[francescobrivio]

PR description:

Forwardport of #35428.
Integrates the former java DIP BeamSpot server as a DQM client:

• By default raeds the value from the txt files
• An option to read the Legacy BeamSpotonline from the DB is added. but not used by default

More details in #35428 and #35193 (comment)
I profit of this PR to remove a couple of commented out lines.

PR validation:

Compiles on lxplus + see #35428

Backport

This is the forward port of #35428.

FYI @sikler

[francescobrivio]

@cmsbuild please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35433/25564

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35433/25564/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35433/25564/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35433/25566

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/BeamMonitor (dqm)
• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29d19/19151/summary.html
COMMIT: 5833f9c
CMSSW: CMSSW_12_1_X_2021-09-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35433/19151/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211046
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

urgent

• my understanding from Francesco was that this is needed for the beam tests, i.e. the backport should be in the 12_0_2

[cmsbuild]

Pull request #35433 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

[perrotta]

@perrotta , @qliphy , although I have restarted the test but last commit is just a technical cleanup, so if urgently needed, please feel free to merge this PR. @cms-sw/dqm-l2 has already signed the previous changes

Thank you @smuzaffar
However I am still waiting for the results of the supposedly ongoing validation at P5 before signing, as for the rest it was only certified that it "compiles runs on lxplus without warning or error message": unless @cms-sw/dqm-l2 or @francescobrivio tell us that we don't need to wait for those tests to complete in order to merge this master version of the PR.

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35433/25606

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #35433 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a29d19/19202/summary.html
COMMIT: b716e85
CMSSW: CMSSW_12_1_X_2021-09-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35433/19202/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Backport 35428 tested in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• As reported in Beamspot DIP server (normal DQM client) #35433 (comment) , tests at P5 ended up succesfully