Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cout from MSLayersKeeperX0DetLayer #3546

Merged

Conversation

Dr15Jones
Copy link
Contributor

In addition to being against CMS policy, the cout was being flagged
as a thread safety issue by valgrind. Also, the printout was happening
once per stream not once per job.
If this functionality is actually needed then the MessageLogger should
be used.

In addition to being against CMS policy, the cout was being flagged
as a thread safety issue by valgrind. Also, the printout was happening
once per stream not once per job.
If this functionality is actually needed then the MessageLogger should
be used.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Remove cout from MSLayersKeeperX0DetLayer

It involves the following packages:

RecoTracker/TkMSParametrization

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 29, 2014

+1

for #3546 8ded66d

tested in CMSSW_7_1_X_2014-04-29-0200
(test area sign360 combined with pulls 3486 3530 3546 3548)
no regressions observed none expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 29, 2014
…0DetLayer

Misc fix -- Remove cout from MSLayersKeeperX0DetLayer
@ktf ktf merged commit 415244f into cms-sw:CMSSW_7_1_X Apr 29, 2014
@Dr15Jones Dr15Jones deleted the removeCoutFromMSLayersKeeperX0DetLayer branch May 6, 2014 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants