Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tags that have [cms_orcon_prod/...] in their name #35546

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Oct 5, 2021

PR description:

The following tags in the autoCond GTs that have the string [cms_orcon_prod/...] in their name:

CSCBadChambers_empty_mc[cms_orcon_prod/CMS_COND_CSC_000]
L1RPCHwConfig_v1[cms_orcon_prod/CMS_COND_36X_RPC]
RPCStripNoises_v1_mc[cms_orcon_prod/CMS_COND_31X_RPC] SiPixelGenErrorDBObject_38T_v1_mc[cms_orcon_prod/CMS_COND_PIXEL_000]         
SiPixelLorentzAngle_forWidth_v1_mc[cms_orcon_prod/CMS_COND_31X_PIXEL]        
SiPixelLorentzAngle_fromAlignment_v1_mc[cms_orcon_prod/CMS_COND_31X_PIXEL]  

The tags without this string were queued to the respective Queues and the following GTs were created, also showing the diff wrt to the previous GT:

This is the HN link:

https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4484.html

And this PR also resolves cms-AlCaDB/AlCaTools#32

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport and no backport is expected.

@tvami
Copy link
Contributor Author

tvami commented Oct 5, 2021

FYI @SanjanaSekhar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35546/25775

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2021

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Oct 5, 2021

test parameters:

  • workflows = 136.897,140.0,200.0,202.0,203.0,204.0,205.0,4001.0,4006.0,4007.0,4008.0,11634.0,12434.0,12834.0,1325.516,50200.0,7.22,145.0,281.0,10424.0,7.21,11224.0,250200.182,11024.2,7.4,12034.0,7.23,159.0,12834.0,7.24

@tvami
Copy link
Contributor Author

tvami commented Oct 5, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2021

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19422/summary.html
COMMIT: c1965b0
CMSSW: CMSSW_12_1_X_2021-10-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35546/19422/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19422/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19422/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc: In member function 'std::unique_ptr MkFitIterationConfigESProducer::produce(const TrackerRecoGeometryRecord&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc:113:46: error: invalid initialization of reference of type 'const mkfit::IterationsInfo&' from expression of type 'const string' {aka 'const std::__cxx11::basic_string'}
  113 |   auto it_conf = mkfit::ConfigJson_Load_File(configFile_);
      |                                              ^~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc:12:
/cvmfs/cms-ib.cern.ch/nweek-02701/slc7_amd64_gcc900/external/mkfit/3.2.0-182127d85853fa8c9c3dacd3aff7fb98/include/mkFit/IterationConfig.h:363:44: note: in passing argument 1 of 'std::unique_ptr mkfit::ConfigJson_Load_File(const mkfit::IterationsInfo&, const string&, mkfit::ConfigJsonPatcher::PatchReport*)'
  363 | ConfigJson_Load_File(const IterationsInfo &its_info, const std::string &fname,


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc:113:57: error: too few arguments to function call, expected at least 2, have 1
  auto it_conf = mkfit::ConfigJson_Load_File(configFile_);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~            ^
/cvmfs/cms-ib.cern.ch/nweek-02701/slc7_amd64_gcc900/external/mkfit/3.2.0-182127d85853fa8c9c3dacd3aff7fb98/include/mkFit/IterationConfig.h:363:1: note: 'ConfigJson_Load_File' declared here
ConfigJson_Load_File(const IterationsInfo &its_info, const std::string &fname,
^


@tvami
Copy link
Contributor Author

tvami commented Oct 5, 2021

@slava77 @jpata this error seems to be related to the mkFit, not really to this PR

@tvami
Copy link
Contributor Author

tvami commented Oct 6, 2021

@perrotta @qliphy have you seen this in the IB building?

@qliphy
Copy link
Contributor

qliphy commented Oct 6, 2021

@tvami

CMSSW_12_1_X_2021-10-05-1100 IB looks ok.
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_12_1_X

Moreover, MKFit PRs #35457 and #35492 are merged after this IB.

@tvami
Copy link
Contributor Author

tvami commented Oct 6, 2021

@tvami

CMSSW_12_1_X_2021-10-05-1100 IB looks ok. https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_12_1_X

Moreover, MKFit PRs #35457 and #35492 are merged after this IB.

Yes, so I'd expect to see something (if there is anything at all) in CMSSW_12_1_X_2021-10-05-2300 , which I guess is not yet out, right?

@qliphy
Copy link
Contributor

qliphy commented Oct 6, 2021

Yes, so I'd expect to see something (if there is anything at all) in CMSSW_12_1_X_2021-10-05-2300 , which I guess is not yet out, right?

Right, CMSSW_12_1_X_2021-10-05-2300 is not out yet. While the test here was based on
CMSSW: CMSSW_12_1_X_2021-10-05-1100/slc7_amd64_gcc900

@tvami
Copy link
Contributor Author

tvami commented Oct 6, 2021

Ok, maybe we should just try to retest?

@tvami
Copy link
Contributor Author

tvami commented Oct 6, 2021

@cmsbuild , please test

@qliphy
Copy link
Contributor

qliphy commented Oct 6, 2021

Ok, maybe we should just try to retest?

The new triggered test is still picking CMSSW_12_1_X_2021-10-05-1100/slc7_amd64_gcc900 as you can find in https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/19425/console

We should wait a bit more for CMSSW_12_1_X_2021-10-05-2300 to appear
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_12_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19425/summary.html
COMMIT: c1965b0
CMSSW: CMSSW_12_1_X_2021-10-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35546/19425/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19425/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19425/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc: In member function 'std::unique_ptr MkFitIterationConfigESProducer::produce(const TrackerRecoGeometryRecord&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc:113:46: error: invalid initialization of reference of type 'const mkfit::IterationsInfo&' from expression of type 'const string' {aka 'const std::__cxx11::basic_string'}
  113 |   auto it_conf = mkfit::ConfigJson_Load_File(configFile_);
      |                                              ^~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc:12:
/cvmfs/cms-ib.cern.ch/nweek-02701/slc7_amd64_gcc900/external/mkfit/3.2.0-182127d85853fa8c9c3dacd3aff7fb98/include/mkFit/IterationConfig.h:363:44: note: in passing argument 1 of 'std::unique_ptr mkfit::ConfigJson_Load_File(const mkfit::IterationsInfo&, const string&, mkfit::ConfigJsonPatcher::PatchReport*)'
  363 | ConfigJson_Load_File(const IterationsInfo &its_info, const std::string &fname,


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-05-1100/src/RecoTracker/MkFit/plugins/MkFitIterationConfigESProducer.cc:113:57: error: too few arguments to function call, expected at least 2, have 1
  auto it_conf = mkfit::ConfigJson_Load_File(configFile_);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~            ^
/cvmfs/cms-ib.cern.ch/nweek-02701/slc7_amd64_gcc900/external/mkfit/3.2.0-182127d85853fa8c9c3dacd3aff7fb98/include/mkFit/IterationConfig.h:363:1: note: 'ConfigJson_Load_File' declared here
ConfigJson_Load_File(const IterationsInfo &its_info, const std::string &fname,
^


@smuzaffar
Copy link
Contributor

please test
new IB with mkFit is now available

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89a423/19426/summary.html
COMMIT: c1965b0
CMSSW: CMSSW_12_1_X_2021-10-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35546/19426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/203.0_H130GGgluonfusion+H130GGgluonfusion+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/204.0_QQH1352T+QQH1352T+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/205.0_ZTT+ZTT+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/250200.182_ZEE_13UP18_RD+ZEE_13UP18_RD+DIGIPRMXUP18_PU25_RD+RECOPRMXUP18_PU25_L1TEgDQM_RD+HARVESTUP18_PU25_L1TEgDQM_RD
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/4001.0_TTbar+TTbar+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/4006.0_SingleElectronFlatPt1To100+SingleElectronFlatPt1To100+DIGIPU1+RECOPU1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/4007.0_QCD_Pt_30_80_BCtoE_8TeV+QCD_Pt_30_80_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/4008.0_QCD_Pt_80_170_BCtoE_8TeV+QCD_Pt_80_170_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/50200.0_ZEE_13+ZEE_13+DIGIUP15_PU50+RECOUP15_PU50_L1TEgDQM+HARVESTUP15_PU50_L1TEgDQM
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89a423/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3219360
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Oct 6, 2021

Ok finally the logs look clean, diffs only in the MsgLogger, otherwise no changes -- as expected

@malbouis
Copy link
Contributor

malbouis commented Oct 6, 2021

+alca

  • The differences in GTs are as expected (only tags with [cms_orcon_prod/*]
  • The failures are only related to the MessageLogger, so no changes wrt the previous GTs, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 7, 2021

+1

@cmsbuild cmsbuild merged commit 641b014 into cms-sw:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace tags that have [cms_orcon_prod/...] in their name
6 participants