Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nano sequence for Premix-ProdLike .9921 relvals #35597

Merged
merged 1 commit into from Oct 11, 2021

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Oct 9, 2021

PR description:

Fix #35596

PR validation:

The following runTheMatrix.py gives the proper config
runTheMatrix.py --what upgrade -l 34834.9921 -t 8 --wm init

if this PR is a backport please specify the original PR and why you need to backport that PR:

No need of backport.

@srimanob
Copy link
Contributor Author

srimanob commented Oct 9, 2021

test parameters:

  • workflows = 23434.9921,34834.9921

@srimanob
Copy link
Contributor Author

srimanob commented Oct 9, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35597/25858

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2021

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Oct 9, 2021

@cmsbuild please test

@perrotta
Copy link
Contributor

perrotta commented Oct 9, 2021

Thank you @srimanob !

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22aa8d/19513/summary.html
COMMIT: 249d36f
CMSSW: CMSSW_12_1_X_2021-10-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35597/19513/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-22aa8d/23434.9921_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU+NanoPU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-22aa8d/34834.9921_TTbar_14TeV+2026D76PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU+NanoPU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2798082
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2798054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Oct 9, 2021

+Upgrade

Technical PR to fix .9921 workflows. One may consider to split between Nano and NanoDQM sequence. That can come in the later PR.

@qliphy
Copy link
Contributor

qliphy commented Oct 11, 2021

@cms-sw/pdmv-l2 Any comment?

@kskovpen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 11, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in 23434.9921 and 34834.9921 workflows
5 participants