EMTF emulator and CSC TP producer changes for the new CCLUT implementation #35632
Conversation
+Moved pattern calculation above the set parameters section in the code. +Added pattern variable which gets passed to conv_hit.set_pattern(pattern) on line 190. +Changed isME11 to isOTMB and (isMEX2 or isME13) to isTMB in both lines 135-139 and 327-330.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35632/25903
|
|
A new Pull Request was created by @eyigitba for master. It involves the following packages:
@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Can this PR be tested? Thanks. |
|
please test |
|
Thanks Andrea! |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cc4f1/19720/summary.html Comparison SummarySummary:
|
|
ping @cms-sw/l1-l2 |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
| # CCLUT for TMB is NOT planned for startup Run-3 | ||
| runCCLUT_TMB = cms.bool(False), | ||
| # CCLUT for OTMB is planned for startup Run-3 | ||
| runCCLUT_OTMB = cms.bool(False), |
There was a problem hiding this comment.
... and therefore why not "true"?
There was a problem hiding this comment.
Because @eyigitba and I would like to postpone enabling runCCLUT_OTMB until EMTF is ready to receive CSC LCTs with enhanced position resolution and bending resolution. It is not yet (new pT lookup tables need to be prepared among others)
There was a problem hiding this comment.
I made this PR #35880 that allows EMTF/OMTF people to study the interface between their systems and the CSC trigger with CCLUT enabled in the OTMBs and/or old TMBs.
|
+1 |
PR description:
Due to hardware limitations, the CCLUT algorithm will not be used in TMBs at the beginning of Run 3. This PR modifies the current CCLUT implementation in CSC TP producer and EMTF emulator to split the cases for TMBs and OTMBs.
After these changes, the CCLUT algorithm can be enabled for CSC stations/rings with OTMBs or TMBs with the specific flags
runCCLUT_OTMBandrunCCLUT_TMBrespectively. Currently, both of the flags are set toFalse, so we expect no change in trigger performance.PR validation:
Validated with
runTheMatrix.py -l limited -i all --ibeosand no changes are observed.if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
FYI @dildick
Before submitting your pull requests, make sure you followed this checklist: