Do not call the fishbone for events with pixel hits only in BPIX1

[fwyzard]

PR description:

Do not call the fishbone for events with pixel hits only in BPIX1.
This avoids a crash when the number of blocks would be zero.

PR validation:

Patatrack pixel track reconstruction can now run on events that previously led to a crash.

[fwyzard]

@VinInn does it look ok to you ?

[fwyzard]

Instruction from @silviodonato to reproduce the crash:

cmsrel CMSSW_12_1_0_pre4
cd CMSSW_12_1_0_pre4
cmsenv
cmsRun /afs/cern.ch/work/s/sdonato/public/CMSSW_12_1_0_pre4/src/hltMinimal.py

leading to

An exception of category 'StdException' occurred while
   [0] Processing  Event run: 323790 lumi: 114 event: 127544888 stream: 1
   [1] Running path 'MC_PFMHT_v16'
   [2] Prefetching for module FastjetJetProducer/'hltAK4PFJets'
   [3] Prefetching for module PixelVertexProducerFromSoA/'hltPixelVertices'
   [4] Prefetching for module PixelVertexSoAFromCUDA/'hltPixelVerticesSoA@cuda'
   [5] Prefetching for module PixelVertexProducerCUDA/'hltPixelVerticesCUDA'
   [6] Calling method for module CAHitNtupletCUDA/'hltPixelTracksCUDA'
Exception Message:
A std::exception was thrown.

/data/cmsbld/jenkins/workspace/auto-builds/CMSSW_12_1_0_pre4-slc7_amd64_gcc900/build/CMSSW_12_1_0_pre4-build/tmp/BUILDROOT/e64968a9c372f8b5b027b5cc5fed93fa/opt/cmssw/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_0_pre4/src/RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu, line 75:
cudaCheck(cudaGetLastError());
cudaErrorInvalidConfiguration: invalid configuration argument
----- End Fatal Exception -------------------------------------------------

This is caused by an event with no hits in BPIX1, which leads to a block size of 0.

This fix adds a check to avoid calling the fishbone in such case.

[fwyzard]

I think this can only happen after #35285, which was not backported to 12.0.x - so there should be no need to backport this fix either.

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35638/25908

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• RecoPixelVertexing/PixelTriplets (reconstruction)

@jpata, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[VinInn]

need to verify. Fishbone should work with three layers as well

[VinInn]

Ok actually the probem is that there are hits ONLY in BPIX1.
One can skip the whole event in such a case...

[fwyzard]

please test

[fwyzard]

One can skip the whole event in such a case...

OK for me.
I've kept the fix minimal, but if you think we can have a more useful logic, please go ahead :-)

[VinInn]

Once is merged I will check again. I'm afraid there could be other instances

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35638/25909

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35638 was updated. @jpata, @slava77 can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bace89/19580/summary.html
COMMIT: 09d56ca
CMSSW: CMSSW_12_1_X_2021-10-12-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35638/19580/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2798054
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• bugfix, no reco change in standard or GPU workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1