Fix CMS deprecated warnings in JetMetCorrections/Modules

[Dr15Jones]

PR description:

• moved modules away from inheriting from legacy types
• added esConsumes to modules and helpers
  • For JME::JetResolution* classes, changes to modules outside of the package was required
• did some memory management improvements

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35681/25972

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• JetMETCorrections/Modules (reconstruction)
• PhysicsTools/PatUtils (reconstruction)
• RecoMET/METProducers (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @ahinzmann, @schoef, @mmarionncern, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @gpetruc, @andrzejnovak, @demuller, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f87a44/19644/summary.html
COMMIT: 2c2b1fa
CMSSW: CMSSW_12_1_X_2021-10-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35681/19644/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals

• 135.4

----- Begin Fatal Exception 14-Oct-2021 23:59:14 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Prefetching for module PATMETSlimmer/'slimmedMETs'
   [4] Prefetching for module CorrectedPATMETProducer/'patPFMetT1JetResUp'
   [5] Prefetching for module ShiftedParticleMETcorrInputProducer/'shiftedPatMETCorrJetResUp'
   [6] Calling method for module SmearedPATJetProducer/'shiftedPatJetResUp'
Exception Message:
No data of type "JME::JetResolutionObject" with label "AK4PFchs" in record "JetResolutionRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

• 158.01

----- Begin Fatal Exception 15-Oct-2021 00:01:07 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMETSlimmer/'slimmedMETs'
   [4] Prefetching for module CorrectedPATMETProducer/'patPFMetT1JetResUp'
   [5] Prefetching for module ShiftedParticleMETcorrInputProducer/'shiftedPatMETCorrJetResUp'
   [6] Calling method for module SmearedPATJetProducer/'shiftedPatJetResUp'
Exception Message:
No data of type "JME::JetResolutionObject" with label "AK4PFchs" in record "JetResolutionRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

• 1325.81

----- Begin Fatal Exception 15-Oct-2021 00:02:02 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'nanoAOD_step'
   [2] Prefetching for module CorrectedPATMETProducer/'patPFMetT1Smear'
   [3] Prefetching for module PATPFJetMETcorrInputProducer/'patPFMetT1T2SmearCorr'
   [4] Prefetching for module PATJetSelector/'selectedPatJetsForMetT1T2SmearCorr'
   [5] Calling method for module SmearedPATJetProducer/'patSmearedJets'
Exception Message:
No data of type "JME::JetResolutionObject" with label "AK4PFchs" in record "JetResolutionRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 9.0
• 25.0
• 1306.0
• 312.0
• 1330.0
• 10042.0
• 10024.0
• 25202.0
• 10824.0
• 11634.0
• 11634.7
• 10224.0
• 11634.912
• 12434.0
• 11634.911
• 23234.0
• 34634.0
• 28234.0
• 250202.181
• 34834.999

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35681/25974

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #35681 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f87a44/19649/summary.html
COMMIT: 18da2f8
CMSSW: CMSSW_12_1_X_2021-10-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35681/19649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2769241
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2769212
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35681 18da2f8

• code changes are technical in line with the PR description
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1