switch loop index to uint from uint16 in FlagsCleanerECAL

[slava77]

this should resolve the problem reported in #35750

In the problematic event there are more than max(uint16) rechits and the loop index can never reach that value by incrementing.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35768/26121

• This PR adds an extra 12KB to repository

[slava77]

@cmsbuild please test

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)

@jpata, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @cbernet, @rovere, @lgray, @clelange, @lecriste, @hatakeyamak, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

type bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1b0c1/19801/summary.html
COMMIT: 806aaba
CMSSW: CMSSW_12_1_X_2021-10-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35768/19801/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Consumes migration of Alignment/ReferenceTrajectories #35259
• @tvami Include new L1 trigger tags in Run-3 MC GTs #35748
• @abhih1 Changes to accommodate Splash events #35755
• @Dr15Jones Use shared_ptr for MutableMonitorElementData #35756

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1b0c1/19801/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1b0c1/19801/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751091
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35768 806aaba

• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

urgent

• well the backport if this is what's really urgent, but that means this is urgent too

[perrotta]

+1