Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Puppi [10_6_X] #35800

Merged
merged 1 commit into from Oct 29, 2021
Merged

Conversation

kpedro88
Copy link
Contributor

backport of #35799

Reason: to speed up ultra-legacy analysis processing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2021

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_10_6_X.

It involves the following packages:

  • CommonTools/PileupAlgos (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @missirol, @ahinzmann, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f8811/19861/summary.html
COMMIT: 7465dfb
CMSSW: CMSSW_10_6_X_2021-10-18-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35800/19861/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1076 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2155
  • DQMHistoTests: Total nulls: 105
  • DQMHistoTests: Total successes: 3213092
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 81.002 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 63.680 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 15.641 KiB Info/EventInfo
  • DQMHistoSizes: changed ( 140.53 ): 1.676 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 140.53 ): 0.006 KiB SiStrip/MechanicalView
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Oct 24, 2021

Reco comparison results: 1076 differences found in the comparisons

almost all of these are in all_OldVSNew_RunHI2011wf140p53 1072 due to The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. .
the rest is also unrelated and appears in the logwarnings coming from the mixing module inputs.

@jpata
Copy link
Contributor

jpata commented Oct 27, 2021

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 29, 2021

+1

@cmsbuild cmsbuild merged commit 716922b into cms-sw:CMSSW_10_6_X Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants