Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide Tracking DNN ESSource also for Fast Simulation #35801

Merged
merged 1 commit into from Oct 25, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 23, 2021

resolves #35797

PR description:

Title says it all.

PR validation:

Run successfully wf 2017.3:

runTheMatrix.py -l 2017.3 -j 4 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Oct 23, 2021

test parameters:

  • workflows = 2017.3, 2018.3, 25403.18, 250402.171

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35801/26165

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • FastSimulation/Tracking (fastsim)

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 23, 2021

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 23, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e78a0d/19863/summary.html
COMMIT: 20b2ba1
CMSSW: CMSSW_12_1_X_2021-10-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35801/19863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e78a0d/2017.3_SingleMuPt100_UP17+SingleMuPt100FS_UP17+HARVESTUP17FS+MINIAODMCUP17FS
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e78a0d/2018.3_SingleMuPt100_UP18+SingleMuPt100FS_UP18+HARVESTUP18FS+MINIAODMCUP18FS
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e78a0d/250402.171_TTbar_13+FS_PREMIXUP17_PU50+FS_TTbar_13_PRMXLOCALUP17_PU50+HARVESTUP17FS
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e78a0d/25403.18_H125GGgluonfusion_13+FS_H125GGgluonfusion_13_UP18_PU50+HARVESTUP18FS+MINIAODMCUP18FS

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2751079
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Oct 24, 2021

@qliphy @perrotta
after #35804 was merged, without this PR all PR tests will be failing

@perrotta
Copy link
Contributor

@qliphy @perrotta after #35804 was merged, without this PR all PR tests will be failing

Yes.
Let wait till tomorrow if @cms-sw/fastsim-l2 has any comment: otherwise, I'd suggest to merge anyhow before tomorrow 1100 IB, and then if fastsim wants to suggest any update, they'll do it with an additional PR

@perrotta
Copy link
Contributor

+1

  • Let have this merged, so that we can get rid of the related FastSim RelVal crashes in the next IB
  • Please @cms-sw/fastsim-l2 provide another PR with uptates/fixes, if you believe that anything different should be preferably applied

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 01228f1 into cms-sw:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IB failures with many workflows
4 participants