Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Patatrack pixel local reconstruction running on CPU #35915

Merged
merged 1 commit into from Nov 1, 2021
Merged

Fix the Patatrack pixel local reconstruction running on CPU #35915

merged 1 commit into from Nov 1, 2021

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 29, 2021

PR description:

Use the hltSiPixelRecHitSoA producer for the pixel rechits in legacy and SoA format, instead of running the legacy producer.

PR validation:

Successfully run the GPU workflow 11634.506.

Running the HLT over 100 TTbar events now shows less discrepancies between the CPU and GPU results.
Before:

      Events    Accepted      Gained        Lost       Other  Trigger
         100          36          +2          -1           -  HLT_Mu3_PFJet40_v16
         100           1          +1           -          ~1  HLT_Mu7p5_Track2_Jpsi_v11
         100          36          +1           -           -  HLT_Mu3_L1SingleMu5orSingleMu7_v1
         100          18           -          -1           -  HLT_Ele15_WPLoose_Gsf_v3
         100          15           -          -1           -  HLT_Ele17_WPLoose_Gsf_v3
         100          14           -          -1           -  HLT_Ele20_WPLoose_Gsf_v6
         100          19          +1           -           -  HLT_Mu12_v3
         100          96           -          -1           -  HLT_DiPFJet15_FBEta3_NoCaloMatched_v17
         100          20          +3          -1           -  HLT_DiPFJet25_FBEta3_NoCaloMatched_v17
         100          98           -          -1           -  HLT_DiPFJetAve40_v14
         100          70          +1          -2           -  HLT_DiPFJetAve60_v14
         100          42          +1           -           -  HLT_DiPFJetAve80_v13
         100          95          +1          -1           -  HLT_DiPFJetAve25_HFJEC_v17
         100          14           -          -3           -  HLT_DiPFJetAve60_HFJEC_v15
         100           4          +1          -1           -  HLT_DiPFJetAve80_HFJEC_v16
         100         100           -          -1           -  HLT_AK8PFJet15_v3
         100         100           -          -1           -  HLT_AK8PFJet40_v16
         100          90          +1          -3           -  HLT_AK8PFJet60_v15
         100          64          +1          -1           -  HLT_AK8PFJet80_v15
         100          19          +1          -3           -  HLT_AK8PFJet140_v15
         100          98          +1          -1           -  HLT_PFJet40_v21
         100          78           -          -1           -  HLT_PFJet60_v21
         100          50          +2           -           -  HLT_PFJet80_v20
         100          17           -          -1           -  HLT_PFJet140_v19
         100          79          +4          -2           -  HLT_PFJetFwd25_v3
         100          28          +2          -2           -  HLT_PFJetFwd40_v19
         100          86          +5          -3           -  HLT_AK8PFJetFwd40_v15
         100          15           -          -1           -  HLT_PFHT370_v17
         100           1           -          -1           -  HLT_PFHT890_v17
         100           3           -          -1           -  HLT_PFMETTypeOne130_PFMHT130_IDTight_v12
         100           2           -          -1           -  HLT_PFMETTypeOne140_PFMHT140_IDTight_v11
         100           6          +1          -1           -  HLT_PFMETNoMu110_PFMHTNoMu110_IDTight_v20
         100           6          +1          -1           -  HLT_MonoCentralPFJet80_PFMETNoMu110_PFMHTNoMu110_IDTight_v20
         100           1           -          -1           -  HLT_PFMETTypeOne200_BeamHaloCleaned_v9
         100           1          +1           -           -  HLT_SingleJet30_Mu12_SinglePFJet40_v11
         100           1          +1           -           -  HLT_Mu12_DoublePFJets40_CaloBTagDeepCSV_p71_v2
         100          18          +1           -           -  HLT_Mu8_TrkIsoVVL_v12
         100           2          +1           -           -  HLT_Mu8_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_DZ_v13
         100           2          +1           -           -  HLT_Mu8_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_DZ_PFDiJet30_v1
         100           2          +1           -           -  HLT_Mu8_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_DZ_CaloDiJet30_v1
         100           3          +1           -           -  HLT_Mu8_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_v11
         100           2          +1           -           -  HLT_Mu12_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_v7
         100           1          +1           -           -  HLT_Mu12_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_DZ_v15
         100           4          +1           -          ~1  HLT_Mu3er1p5_PFJet100er2p5_PFMET70_PFMHT70_IDTight_v2
         100           3          +1           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMET80_PFMHT80_IDTight_v2
         100           1          +1           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMET90_PFMHT90_IDTight_v2
         100           4          +1           -          ~1  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu70_PFMHTNoMu70_IDTight_v2
         100           4          +1           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu80_PFMHTNoMu80_IDTight_v2
         100           4          +1          -1           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu90_PFMHTNoMu90_IDTight_v2
         100           4          +1          -1           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu100_PFMHTNoMu100_IDTight_v2
         100          23          +1           -           -  HLT_Mu8_v12
         100          20           -          -1           -  HLT_Ele8_CaloIdL_TrackIdL_IsoVL_PFJet30_v16
         100          19           -          -1           -  HLT_Ele12_CaloIdL_TrackIdL_IsoVL_PFJet30_v18
         100          18           -          -1           -  HLT_Ele15_CaloIdL_TrackIdL_IsoVL_PFJet30_v3
         100          13           -          -1           -  HLT_Ele23_CaloIdL_TrackIdL_IsoVL_PFJet30_v18
         100          22          +1          -1           -  HLT_Ele8_CaloIdM_TrackIdM_PFJet30_v18
         100          16           -          -1           -  HLT_Ele17_CaloIdM_TrackIdM_PFJet30_v16
         100          14           -          -1           -  HLT_Ele23_CaloIdM_TrackIdM_PFJet30_v18
         100           5           -          -1          ~1  HLT_PFHT330PT30_QuadPFJet_75_60_45_40_TriplePFBTagDeepCSV_4p5_v3
         100           5           -          -1          ~1  HLT_PFHT400_SixPFJet32_DoublePFBTagDeepCSV_2p94_v8
         100           6           -          -2           -  HLT_PFHT400_SixPFJet32_v8
         100           5           -          -1           -  HLT_PFHT400_FivePFJet_100_100_60_30_30_v8
         100           3           -          -1           -  HLT_PFHT400_FivePFJet_100_100_60_30_30_DoublePFBTagDeepCSV_4p5_v8
         100           3           -          -1           -  HLT_PFHT400_FivePFJet_120_120_60_30_30_DoublePFBTagDeepCSV_4p5_v8
         100          20           -          -1           -  HLT_PFHT350MinPFJet15_v9
         100          50          +2           -           -  HLT_AK4PFJet80_v19
         100          31          +2           -           -  HLT_AK4PFJet100_v19
         100          24          +1           -           -  HLT_AK4PFJet120_v18
         100          85           -          -1           -  MC_PFBTagDeepCSV_v10
         100          10          +2          -1          ~2  HLT_PFMETNoMu100_PFMHTNoMu100_IDTight_PFHT60_v9
         100           6          +1           -           -  HLT_QuadPFJet105_88_76_15_v5
         100           4          +1           -           -  HLT_QuadPFJet111_90_80_15_v5
         100          22          +1           -           -  HLT_Mu9_IP0_part0_v2
         100          22          +1           -           -  HLT_TrkMu6NoFiltersNoVtx_v1
         100          17          +1           -           -  HLT_TrkMu16NoFiltersNoVtx_v1
         100         100           -        -100           -  Status_OnCPU
         100           0        +100           -           -  Status_OnGPU

After:

      Events    Accepted      Gained        Lost       Other  Trigger
         100          37          +1          -1           -  HLT_Mu3_PFJet40_v16
         100          18           -          -1           -  HLT_Ele15_WPLoose_Gsf_v3
         100          15           -          -1           -  HLT_Ele17_WPLoose_Gsf_v3
         100          14           -          -1           -  HLT_Ele20_WPLoose_Gsf_v6
         100          96           -          -1           -  HLT_DiPFJet15_FBEta3_NoCaloMatched_v17
         100          20          +3          -1           -  HLT_DiPFJet25_FBEta3_NoCaloMatched_v17
         100          98           -          -1           -  HLT_DiPFJetAve40_v14
         100          70          +1          -2           -  HLT_DiPFJetAve60_v14
         100          43          +1          -1           -  HLT_DiPFJetAve80_v13
         100          94          +1           -           -  HLT_DiPFJetAve25_HFJEC_v17
         100          13           -          -2           -  HLT_DiPFJetAve60_HFJEC_v15
         100           4          +1          -1           -  HLT_DiPFJetAve80_HFJEC_v16
         100         100           -          -1           -  HLT_AK8PFJet15_v3
         100         100           -          -1           -  HLT_AK8PFJet40_v16
         100          90          +1          -3           -  HLT_AK8PFJet60_v15
         100          66          +1          -3           -  HLT_AK8PFJet80_v15
         100          18          +1          -2           -  HLT_AK8PFJet140_v15
         100          98          +1          -1           -  HLT_PFJet40_v21
         100          78           -          -1           -  HLT_PFJet60_v21
         100          51          +1           -           -  HLT_PFJet80_v20
         100          17           -          -1           -  HLT_PFJet140_v19
         100          79          +4          -2           -  HLT_PFJetFwd25_v3
         100          29          +1          -2           -  HLT_PFJetFwd40_v19
         100          87          +4          -3           -  HLT_AK8PFJetFwd40_v15
         100          15           -          -1           -  HLT_PFHT370_v17
         100           1           -          -1           -  HLT_PFHT890_v17
         100           3          +1           -          ~1  HLT_PFMETNoMu120_PFMHTNoMu120_IDTight_PFHT60_v9
         100           3           -          -1           -  HLT_PFMETTypeOne130_PFMHT130_IDTight_v12
         100           2           -          -1           -  HLT_PFMETTypeOne140_PFMHT140_IDTight_v11
         100           7          +1          -2           -  HLT_PFMETNoMu110_PFMHTNoMu110_IDTight_v20
         100           3          +1           -          ~1  HLT_PFMETNoMu120_PFMHTNoMu120_IDTight_v20
         100           7          +1          -2           -  HLT_MonoCentralPFJet80_PFMETNoMu110_PFMHTNoMu110_IDTight_v20
         100           3          +1           -          ~1  HLT_MonoCentralPFJet80_PFMETNoMu120_PFMHTNoMu120_IDTight_v20
         100           1           -          -1           -  HLT_PFMETTypeOne200_BeamHaloCleaned_v9
         100           1           -          -1           -  HLT_DoubleMu3_DZ_PFMET90_PFMHT90_v10
         100           3          +2           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMET70_PFMHT70_IDTight_v2
         100           3          +1           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMET80_PFMHT80_IDTight_v2
         100           2          +1          -1           -  HLT_Mu3er1p5_PFJet100er2p5_PFMET90_PFMHT90_IDTight_v2
         100           4          +1           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu70_PFMHTNoMu70_IDTight_v2
         100           4          +1           -           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu80_PFMHTNoMu80_IDTight_v2
         100           4          +1          -1           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu90_PFMHTNoMu90_IDTight_v2
         100           4          +1          -1           -  HLT_Mu3er1p5_PFJet100er2p5_PFMETNoMu100_PFMHTNoMu100_IDTight_v2
         100          21          +1           -           -  HLT_Ele8_CaloIdM_TrackIdM_PFJet30_v18
         100           5           -          -1          ~1  HLT_PFHT330PT30_QuadPFJet_75_60_45_40_TriplePFBTagDeepCSV_4p5_v3
         100           5           -          -1           -  HLT_PFHT400_SixPFJet32_DoublePFBTagDeepCSV_2p94_v8
         100           5           -          -1           -  HLT_PFHT400_SixPFJet32_v8
         100           4          +1          -1           -  HLT_PFHT400_FivePFJet_100_100_60_30_30_v8
         100           3           -          -1          ~1  HLT_PFHT400_FivePFJet_100_100_60_30_30_DoublePFBTagDeepCSV_4p5_v8
         100           3           -          -1           -  HLT_PFHT400_FivePFJet_120_120_60_30_30_DoublePFBTagDeepCSV_4p5_v8
         100          22           -          -3           -  HLT_PFHT350MinPFJet15_v9
         100          51          +1           -           -  HLT_AK4PFJet80_v19
         100          31          +2           -           -  HLT_AK4PFJet100_v19
         100          10          +2          -1          ~1  HLT_PFMETNoMu100_PFMHTNoMu100_IDTight_PFHT60_v9
         100         100           -        -100           -  Status_OnCPU
         100           0        +100           -           -  Status_OnGPU

@VinInn @fwyzard
Fix the Patatrack pixel local reconstruction running on CPU
9d47101 
Use the hltSiPixelRecHitSoA producer for the pixel rechits in legacy and
SoA format, instead of running the legacy producer.
@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Oct 29, 2021
@fwyzard fwyzard mentioned this pull request Oct 29, 2021
Merged
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 29, 2021

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 29, 2021

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35915/26314

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

please abort

@missirol
Copy link
Contributor

test parameters:

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09cba3/20091/summary.html
COMMIT: 9d47101
CMSSW: CMSSW_12_2_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35915/20091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

  • despite the label, this PR did not require any externals (and the other PR, which fixed one of the tests, is already merged)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@VinInn
Copy link
Contributor

VinInn commented Oct 30, 2021 •
edited

FYI @OzAmram @mmusich @tsusa @vmariani @czangela

@qliphy
Copy link
Contributor

qliphy commented Nov 1, 2021

+1

@cmsbuild cmsbuild merged commit 9f13336 into cms-sw:master Nov 1, 2021
@cmsbuild cmsbuild mentioned this pull request Nov 1, 2021
Merged
@silviodonato silviodonato mentioned this pull request Nov 15, 2021
Open
@fwyzard fwyzard deleted the fix_hltSiPixelRecHitSoA_121x branch July 31, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved fully-signed hlt-approved orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_12_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fwyzard @cmsbuild @missirol @VinInn @qliphy