Replace `boost/regex.hpp` with standard library `regex` #35919

guitargeek · 2021-10-31T01:06:17Z

PR description:

Title says it all: a boost feature is replaced with the corresponding standard library feature.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

guitargeek · 2021-10-31T10:33:43Z

Something went wrong with the daylight saving time transition I guess... I'll try to force push again

cmsbuild · 2021-10-31T10:43:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35919/26324

This PR adds an extra 140KB to repository

cmsbuild · 2021-10-31T10:44:06Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibTracker/SiStripCommon (alca)
Calibration/HcalAlCaRecoProducers (alca)
CommonTools/Utils (reconstruction)
DQM/HLTEvF (dqm, hlt)
DQMOffline/Trigger (dqm)
DQMServices/StreamerIO (dqm)
DataFormats/PatCandidates (reconstruction)
EventFilter/L1TRawToDigi (l1)
Fireworks/Core (visualization)
HLTrigger/Timer (hlt)
JetMETCorrections/IsolatedParticles (analysis)
PhysicsTools/FWLite (analysis)
RecoLocalTracker/SiPixelRecHits (reconstruction)
RecoLuminosity/LumiProducer (reconstruction)
RecoTracker/FinalTrackSelectors (reconstruction)
TrackingTools/TrackAssociator (reconstruction)

@malbouis, @alja, @yuanchao, @rekovic, @makortel, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @missirol, @Dr15Jones, @jfernan2, @Martin-Grunewald, @slava77, @jpata, @francescobrivio, @santocch, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @felicepantaleo, @hatakeyamak, @robervalwalsh, @CeliaFernandez, @Martin-Grunewald, @bsunanda, @OzAmram, @thomreis, @ahinzmann, @missirol, @threus, @mmusich, @seemasharmafnal, @mmarionncern, @calderona, @silviodonato, @JanFSchulte, @jhgoh, @jdolen, @HuguesBrun, @cericeci, @ferencek, @pieterdavid, @rociovilar, @sscruz, @abbiendi, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @dinyar, @nhanvtran, @gkasieczka, @tocheng, @schoef, @ebrondol, @mtosi, @dgulhan, @clelange, @bellan, @trocino, @gbenelli, @Fedespring, @alja, @dkotlins, @lecriste, @cbernet, @gpetruc, @mariadalfonso, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-10-31T11:04:21Z

@cmsbuild , please test

cmsbuild · 2021-10-31T12:40:15Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f3b8e/20114/summary.html
COMMIT: f971bcf
CMSSW: CMSSW_12_2_X_2021-10-31-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35919/20114/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f3b8e/20114/llvm-analysis/legacy-mod-sa.txt for details.

RelVals

135.4

----- Begin Fatal Exception 31-Oct-2021 12:48:24 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 31-Oct-2021 12:49:01 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 31-Oct-2021 12:49:01 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log

Expand to see more relval errors ...

AddOn Tests

fastsim1

----- Begin Fatal Exception 31-Oct-2021 12:45:37 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 31-Oct-2021 12:45:38 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 31-Oct-2021 12:49:32 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

slava77 · 2021-10-31T12:46:53Z

@cmsbuild please test with #35766

qliphy · 2022-03-24T01:04:32Z

@guitargeek I notice this is reopened while the milestone is still 12_2_X. I have changed it to 12_4_X which is current master.

jpata · 2022-03-24T15:15:35Z

@guitargeek do you plan to work on this, should we review?

guitargeek · 2022-03-24T15:42:32Z

Yes I plan to work on this, because I realized now how we can fix the problem with the slow regex that @davidlange6 mentioned: #35919 (comment) (because I had a similar problem in RooFit: root-project/root#10205).

The construction of std::regex objects is expensive because the regex needs to be compiled, and this compile cost seems to be higher for the std:: than the boost implementation. If we about compiling a single regex multiple times by making it static const, we can make the regex compile time negligible and then it doesn't matter if we use boost or std::regex (and then this PR will also bring a speedup in workflows with many regex).

guitargeek · 2022-03-24T15:43:28Z

So I plan to update this PR turning the std::regex to static const std::regex.

yuanchao · 2022-03-25T06:59:36Z

@guitargeek Did you test the performance for the static const case? Let us know when this PR is ready for review.

tvami · 2022-04-05T13:57:47Z

Hi @guitargeek do you maybe have an update on this? Thanks!

jpata · 2022-04-14T13:17:34Z

just a kind ping on this.

cecilecaillol · 2022-04-14T13:21:13Z

+l1

mmusich · 2022-04-14T13:31:51Z

hold

waiting on inputs for Replace boost/regex.hpp with standard library regex #35919 (comment)

cmsbuild · 2022-04-14T13:32:12Z

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

tvami · 2022-04-21T01:28:57Z

A kind ping to @guitargeek , could you please let us know the ETA for the change of std::regex to static const std::regex?

tvami · 2022-05-02T13:48:40Z

-alca

to remove from the alca queues, we'll resign when the std::regex is dealt with

alja · 2022-05-02T16:56:41Z

+1

emanueleusai · 2022-05-05T15:49:10Z

-1

removing from DQM queues. We'll resign when the std::regex is dealt with

jpata · 2022-05-09T13:40:39Z

-reconstruction

removing from reco queues until it's updated

guitargeek · 2022-05-10T13:03:18Z

Closing again because of lack of time :(

Replace boost/regex.hpp with standard library regex

f971bcf

cmsbuild added this to the CMSSW_12_2_X milestone Oct 31, 2021

cmsbuild added the future-commit label Oct 31, 2021

cmsbuild added alca-pending analysis-pending code-checks-pending dqm-pending hlt-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending visualization-pending and removed future-commit labels Oct 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 31, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 31, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 31, 2021

cmsbuild added requires-external tests-started and removed tests-rejected labels Oct 31, 2021

qliphy added this to the CMSSW_12_4_X milestone Mar 24, 2022

cmsbuild mentioned this pull request Mar 29, 2022

Fixing FastTimerClient Hist Remaking Issue : 12_4_X #37402

Merged

cmsbuild added l1-approved and removed l1-pending labels Apr 14, 2022

cmsbuild added the hold label Apr 14, 2022

cmsbuild added alca-rejected and removed alca-pending labels May 2, 2022

cmsbuild added visualization-approved and removed visualization-pending labels May 2, 2022

cmsbuild added dqm-rejected and removed dqm-pending labels May 5, 2022

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels May 9, 2022

guitargeek closed this May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `boost/regex.hpp` with standard library `regex` #35919

Replace `boost/regex.hpp` with standard library `regex` #35919

guitargeek commented Oct 31, 2021 •

edited

guitargeek commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

tvami commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

slava77 commented Oct 31, 2021

qliphy commented Mar 24, 2022

jpata commented Mar 24, 2022

guitargeek commented Mar 24, 2022

guitargeek commented Mar 24, 2022

yuanchao commented Mar 25, 2022

tvami commented Apr 5, 2022

jpata commented Apr 14, 2022

cecilecaillol commented Apr 14, 2022

mmusich commented Apr 14, 2022

cmsbuild commented Apr 14, 2022

tvami commented Apr 21, 2022

tvami commented May 2, 2022

alja commented May 2, 2022

emanueleusai commented May 5, 2022

jpata commented May 9, 2022

guitargeek commented May 10, 2022

Replace boost/regex.hpp with standard library regex #35919

Replace boost/regex.hpp with standard library regex #35919

Conversation

guitargeek commented Oct 31, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

guitargeek commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

tvami commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

RelVals

RelVals-INPUT

AddOn Tests

slava77 commented Oct 31, 2021

qliphy commented Mar 24, 2022

jpata commented Mar 24, 2022

guitargeek commented Mar 24, 2022

guitargeek commented Mar 24, 2022

yuanchao commented Mar 25, 2022

tvami commented Apr 5, 2022

jpata commented Apr 14, 2022

cecilecaillol commented Apr 14, 2022

mmusich commented Apr 14, 2022

cmsbuild commented Apr 14, 2022

tvami commented Apr 21, 2022

tvami commented May 2, 2022

alja commented May 2, 2022

emanueleusai commented May 5, 2022

jpata commented May 9, 2022

guitargeek commented May 10, 2022

Replace `boost/regex.hpp` with standard library `regex` #35919

Replace `boost/regex.hpp` with standard library `regex` #35919

guitargeek commented Oct 31, 2021 •

edited