Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for TestDQMServicesDemo unit test #35921

Merged
merged 1 commit into from Nov 2, 2021

Conversation

missirol
Copy link
Contributor

PR description:

This PR tries to fix the DQM unit test TestDQMServicesDemo.
It looks like some API calls in DQM-related scripts needed to be adjusted after the switch from uproot-3 to uproot-4.
See #35868 for some more details.

PR validation:

The relevant unit test now passes.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35921/26326

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • DQMServices/Components (dqm)
  • DQMServices/Demo (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test with #35766

(abusing my testing rights to test this quickly; the other PR seems to be needed to avoid issues in unrelated wfs)

@qliphy
Copy link
Contributor

qliphy commented Oct 31, 2021

type bugfix

@qliphy
Copy link
Contributor

qliphy commented Oct 31, 2021

urgent

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c763d6/20118/summary.html
COMMIT: b272e1c
CMSSW: CMSSW_12_2_X_2021-10-31-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35921/20118/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
135.4 step 1
136.8311 step 2
136.7611 step 2
136.88811 step 2
4.22 step 3
140.56 step 2
4.53 step 3
136.731 step 3
136.793 step 3
136.874 step 3
2018.1 step 1
1001.0 step 2
1000.0 step 2
1306.0 step 3
1330.0 step 3
312.0 step 3
10042.0 step 3
10024.0 step 3
10824.0 step 3
25202.0 step 3
11634.0 step 3
11634.7 step 3
11634.914 step 3
10224.0 step 3
11634.911 step 3
12434.0 step 3
23234.0 step 3
34634.0 step 3
38634.0 step 3
28234.0 step 3
250202.181 step 4
34834.999 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 22557 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 9
  • DQMHistoTests: Total histograms compared: 304467
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 304459
  • DQMHistoTests: Total skipped: 8
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
  • Checked 118 log files, 16 edm output root files, 9 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 1, 2021

+1
Thank you @missirol

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 2, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants