Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement of a workaround in customizeHLTforPatatrack #36031

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Nov 8, 2021

PR description:

Recent changes in the HLT menu [*] (addition of a module in the path AlCa_LumiPixelsCounts_Random_v1; see CMSHLT-2189) have created a conflict between the 12_2_X GRun menu and a workaround used in customizeHLTforPatatrack.

This PR fixes the issue with a small improvement to said workaround.
The final solution will be to fix the HLT path directly in ConfDB (this is being followed up in TSG; see CMSHLT-2195).

FYI: @fwyzard

[*] To be integrated in CMSSW in a separate PR later today. See #36034.

PR validation:

Manual tests. Now the following works:

hltGetConfiguration /dev/CMSSW_12_2_0/GRun \
 --input $(dasgoclient -query "file dataset=/RelValVBFHZZ4Nu_14TeV/CMSSW_12_1_0_pre4-121X_mcRun3_2021_realistic_v10-v1/GEN-SIM-DIGI-RAW" -limit 1) \
 --globaltag auto:run3_mc_GRun --mc --eras Run3 --prescale none --max-events 50 \
 --customise HLTrigger/Configuration/customizeHLTforPatatrack.customizeHLTforPatatrack > hlt.py \
 && cmsRun hlt.py

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36031/26486

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Nov 8, 2021

enable gpu

to test wfs that make use of customizeHLTforPatatrack

@missirol
Copy link
Contributor Author

missirol commented Nov 8, 2021

please test with #36021

looks like this other unrelated PR is necessary to fix some of the PR tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8c569/20325/summary.html
COMMIT: 2ae342b
CMSSW: CMSSW_12_2_X_2021-11-08-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36031/20325/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19782
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19758
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 2694541
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694507
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 173 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Nov 8, 2021

+hlt

  • despite the label, this PR did not require any externals
    (another PR was needed to work around an unrelated issue in PR tests)

@qliphy @perrotta
I think it would be best to merge this PR before, or together with, #36034
(to avoid any possible conflict between the new HLT menu and the 'old' version of customizeHLTforPatatrack)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 8, 2021

+1

@cmsbuild cmsbuild merged commit 8d204b0 into cms-sw:master Nov 8, 2021
@missirol missirol deleted the devel_hltCustomPatatrackAlCaPaths_v2 branch November 9, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants