New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL PoolDBOutput code migration #36062
ECAL PoolDBOutput code migration #36062
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36062/26526
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @rekovic, @yuanchao, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
const auto handle = evtSetup.getHandle(pedestalsToken_); | ||
const EcalTPGPedestals* obj = handle.product(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const auto handle = evtSetup.getHandle(pedestalsToken_); | |
const EcalTPGPedestals* obj = handle.product(); | |
const auto obj = &evtSetup.getData(pedestalsToken_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that would be even better.
But it could be const auto& obj = evtSetup.getData(pedestalsToken_);
in fact.
Hi @thomreis I think this should go in the other direction, make the |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36062/26539
|
Pull request #36062 was updated. @malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @rekovic, @yuanchao, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9043b3/20428/summary.html Comparison SummarySummary:
|
+alca
|
+1 |
+db |
+1 |
merge |
This addresses parts of cms-AlCaDB/AlCaTools#41 as well. |
PR description:
This PR migrates ECAL related code to new PoolDBOutput functions
writeOneIOV
,createOneIOV
, andappendOneIOV
as described in https://indico.cern.ch/event/1088598/contributions/4580152/attachments/2333275/3976721/DBOutputService%20changes.pdf .Some code cleaning is done in addition.
PR validation:
The code compiles and test configurations (if existing) were run without an issue.