Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made static const in LinkByRecHit #3607

Merged

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made static const in LinkByRecHit

It involves the following packages:

RecoParticleFlow/PFClusterTools

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Apr 30, 2014

Wouldn't it be better to just make this constexpr? Or is this the same result from the compiler in the end?

@Dr15Jones
Copy link
Contributor Author

I'm betting the compiler would treat it the same.

@lgray
Copy link
Contributor

lgray commented Apr 30, 2014

bon.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@slava77
Copy link
Contributor

slava77 commented May 1, 2014

+1

for #3607 81ce937

~ trivial

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 1, 2014
…cHit

Multithreading -- Made static const in LinkByRecHit
@ktf ktf merged commit 6979599 into cms-sw:CMSSW_7_1_X May 1, 2014
@Dr15Jones Dr15Jones deleted the changeStaticToConstInLinkByRecHit branch May 6, 2014 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants