Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLANG warning cleanup #3614

Merged
merged 2 commits into from May 1, 2014
Merged

CLANG warning cleanup #3614

merged 2 commits into from May 1, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Apr 30, 2014

Cleanup some CLANG compiler warning in Core
packages related to unused variables and expressions.

@wddgit
CLANG warning cleanup
11a30b5 
Cleanup some CLANG compiler warning in Core
packages related to unused variables and expressions.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

CLANG warning cleanup

It involves the following packages:

DataFormats/FWLite
FWCore/FWLite
IOPool/Common

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Dr15Jones
Dr15Jones reviewed Apr 30, 2014
View reviewed changes
DataFormats/FWLite/test/test.cppunit.cpp
@@ -238,7 +238,7 @@ void testRefInROOT::testRefFirst()
for(edmtest::OtherThingCollection::const_iterator itOther=pOthers->begin(), itEnd=pOthers->end() ;
itOther != itEnd; ++itOther) {
//std::cout <<"getting ref"<<std::endl;
itOther->ref.get()->a;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of printing stuff from unit tests. How about testing that it isn't some large value?

@wddgit
CLANG Warning cleanup
36a423e 
Instead of eliminating the unused warning by
printing the unused expression, compare it
to an arbitrary large number.
@cmsbuild
Copy link
Contributor

Pull request #3614 was updated. @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 1, 2014
@davidlange6
Merge pull request #3614 from wddgit/clangWarningCleanupInCore
00bf4a6 
CLANG warning cleanup
@davidlange6 davidlange6 merged commit 00bf4a6 into cms-sw:CMSSW_7_1_X May 1, 2014
@wddgit wddgit deleted the clangWarningCleanupInCore branch August 27, 2014 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-approved fully-signed tests-pending
Projects
None yet
Milestone
CMSSW_7_1_0_pre8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wddgit @cmsbuild @Dr15Jones @davidlange6