TkDQM: Add checks to avoid Segfault when a ME is not present at harvesting step

[arossi83]

PR description:

When a couple of TkDQM harvesting module don't find the MEs which in principle should had been produced in the previous step a segmentation fault happen, as reported here #36133. With this PR we introduce a couple of simple check to avoid the this behaviour, if MEs are not produced the modules will be skipped.

PR validation:

runTheMatrix.sh -l 10024
runTheMatrix.sh -l 139.001 (with #36133 locally merged)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport needed

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36151/26695

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36151/26695/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36151/26695/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

@arossi83 please apply code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36151/26697

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

• DQM/SiPixelPhase1Track (dqm)
• DQM/TrackingMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @JanFSchulte, @VinInn, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflows = 10024, 139.001

[mmusich]

@cmsbuild, please test with #36133

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0c03e/20583/summary.html
COMMIT: eb26ef5
CMSSW: CMSSW_12_2_X_2021-11-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36151/20583/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 138.5138.5_ExpressCollisions+RunMinimumBias2021+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+ALCARECOEXPR3+HARVESTDEXPR3.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b0c03e/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3327156
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327134
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

The error looks unrelated to this PR:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0c03e/20583/runTheMatrixINPUT-results/138.5_ExpressCollisions+RunMinimumBias2021+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+ALCARECOEXPR3+HARVESTDEXPR3.log

[mmusich]

@cmsbuild, please test with #36133

[perrotta]

please test
(The fixes were rather obvious, thus I tested my superpowers and I implemented them myself)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36151/26805

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #36151 was updated. @emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0c03e/20677/summary.html
COMMIT: 2b13e67
CMSSW: CMSSW_12_2_X_2021-11-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36151/20677/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b0c03e/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247021
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246999
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1