Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making beamspot DIP server more verbose and additional fixes [12_2_X] (forward port to master) #36152

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Making beamspot DIP server more verbose and additional fixes [12_2_X] (forward port to master) #36152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions DQM/BeamMonitor/plugins/BeamSpotDipServer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ BeamSpotDipServer::BeamSpotDipServer(const edm::ParameterSet& ps) {
dip = Dip::create("CmsBeamSpotServer");

//
dip->setDNSNode("dipns1,dipns2");
dip->setDNSNode("cmsdimns1.cern.ch");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not configure it via parameter set?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smuzaffar! There are a few other suggestions that you gave in the past on the DIP client and that I have on my todo list for future improvements of this plugin. Is it ok if I add this one to the list and we take care of it in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, it is ok.


edm::LogInfo("BeamSpotDipServer") << "reading from " << (readFromNFS ? "file (NFS)" : "database");
}
Expand Down Expand Up @@ -734,10 +734,10 @@ void BeamSpotDipServer::publishRcd(string qlty, string err, bool pubCMS, bool fi

// send
if (updateCMS)
publicationCMS->send(messageCMS, zeit);
publicationCMS->send(*messageCMS, zeit);

publicationLHC->send(messageLHC, zeit);
publicationPV->send(messagePV, zeit);
publicationLHC->send(*messageLHC, zeit);
publicationPV->send(*messagePV, zeit);

// set qualities
if (qlty == qualities[0]) { // Uncertain
Expand Down
14 changes: 14 additions & 0 deletions DQM/Integration/python/clients/beamspotdip_dqm_sourceclient-live_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@
process = cms.Process("BeamSpotDipServer")
process.load("DQMServices.Core.DQM_cfg")

# message logger
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.cerr = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
default = cms.untracked.PSet(
limit = cms.untracked.int32(100000)
),
BeamSpotDipServer = cms.untracked.PSet(
limit = cms.untracked.int32(100000)
)
)

# input
# for live online DQM in P5
process.load("DQM.Integration.config.inputsource_cfi")
Expand All @@ -34,6 +46,8 @@
# module
process.load("DQM.BeamMonitor.BeamSpotDipServer_cff")

process.beamSpotDipServer.verbose = cms.untracked.bool(True)

# process customizations included here
from DQM.Integration.config.online_customizations_cfi import *
process = customise(process)
Expand Down