Modify calculations for the SiPixel Lorentz Angle calibration in PCL

[tvami]

PR description:

Essentially a fix of the method: the previous implementation was not in line with the calibration method used to create the CPE objects.

The calculation for LA is modified in this PR in order to take into account the changes on the drift-depth shape after irradiation.

As can be seen from this figure [1], the drift-depth shape changes from a solid blue line to an s-shaped (shown in red) curve after irradiation. The average displacement becomes smaller and the slope in the central region becomes larger.
In order to correct for the displacement around central region, Morris proposed to evaluate the LA at depth T/2 and obtain tan\theta_L = 2(D_1/2)/T as shown in green, which helps to monitor displacement of charge carriers around central region and thus is better for calibration purpose.

[1] https://github.com/CMSTrackerDPG/cmssw/files/7552567/LA_irradiated.pdf

PR validation:

code compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

Would be nice to have it in 12_1_X T0 replay

Submitting the PR for @wweiphy

[tvami]

type bugfix

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36241/26873

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelLorentzAngle/src/SiPixelLorentzAnglePCLWorker.cc modified in PR(s): Phase II Patatrack Pixel Local Reco #36235

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36241/26873/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36241/26873/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[tvami]

test parameters:

• workflows = 1001.2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36241/26874

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelLorentzAngle/src/SiPixelLorentzAnglePCLWorker.cc modified in PR(s): Phase II Patatrack Pixel Local Reco #36235

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflows = 1001.2

@tvami, what's the point of exercising 1001.2?
As far as I can tell the harvesting step of the SiPixelLorentzAngle is not exercised:

1001.2 RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL [1]: input from: /ZeroBias/Run2017F-v1/RAW with run [] 
                                           [2]: cmsDriver.py step2  --conditions auto:run2_data -s RAW2DIGI,L1Reco,RECO,EI,ALCAPRODUCER:@allForExpress+AlCaPCCZeroBiasFromRECO+AlCaPCCRandomFromRECO,DQM:@express,ENDJOB --datatier ALCARECO,DQMIO --eventcontent ALCARECO,DQM --data  --process RECO --scenario pp --customise Configuration/DataProcessing/RecoTLR.customiseExpress --era Run2_2017 -n 100 
                                           [3]: cmsDriver.py step3  -s ALCAOUTPUT:SiStripCalZeroBias+TkAlMinBias+LumiPixelsMinBias+AlCaPCCZeroBiasFromRECO+AlCaPCCRandomFromRECO+SiPixelCalZeroBias+SiPixelCalSingleMuon,ALCA:PromptCalibProd+PromptCalibProdSiStrip+PromptCalibProdSiStripGains+PromptCalibProdSiStripGainsAAG+PromptCalibProdSiPixelAli+PromptCalibProdSiPixel+PromptCalibProdSiPixelLorentzAngle --conditions auto:run2_data --datatier ALCARECO --eventcontent ALCARECO --triggerResultsProcess RECO -n 100 
                                           [4]: cmsDriver.py step4  -s ALCAHARVEST:SiPixelQuality --conditions auto:run3_data_express --scenario pp --data  --era Run2_2017 --filein file:PromptCalibProdSiPixel.root -n 100 

1 workflows with 4 steps
 -------------------------------------------------------------------------------- 

perhaps a step5

[5] cmsDriver.py step4  -s ALCAHARVEST:SiPixelLA --conditions auto:run3_data_express --scenario pp --data  --era Run2_2017 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n 100 

could be added to this PR...

[tvami]

Hi @mmusich you are right, I have hoped that your proposed step5 was already there. Thanks for checking. Since I have somewhat little access to CMSTrackerDPG I propose to add that step in a different PR. Also w/o that, this PR is just an AlCA signature so it would go it quicker. Alternatively I can make the other PR right now and test together with this one.

[tvami]

test parameters:

• workflows = 1001.2

[tvami]

@cmsbuild , please test with #36245

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-144836/20749/summary.html
COMMIT: b51d358
CMSSW: CMSSW_12_2_X_2021-11-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36241/20749/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-144836/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247025
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247002
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

Comparing the old method from
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5abfd2/20754/runTheMatrix-results/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA/DQM_V0001_R000305064__Express__PCLTest__ALCAPROMPT.root

with the outcome of this test
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-144836/20749/runTheMatrix-results/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA/DQM_V0001_R000305064__Express__PCLTest__ALCAPROMPT.root

We can see that the new version is more stable

[mmusich]

We can see that the new version is more stable

There's also the one produced by 1001.0:
https://tinyurl.com/yyfjrwxs

[mmusich]

any comments to this one? I thought we'd like to push this through for a backport.

[tvami]

Yeah Francesco told me he had a look, so I think I'll just sign this one....

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1