Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miscalibration tools in CondTools/SiStrip #36334

Merged
merged 4 commits into from Dec 3, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 2, 2021

PR description:

Investigation in response to #36319.
Updates:

  • SiStripNoisesFromDBMiscalibrator: put SiStripNoises object on the stack, add printDebug statements (daab356)
  • SiStripChannelGainFromDBMiscalibrator: put SiStripApvGain object on the stack, add printDebug statements (f4a93a7)
  • change names of output sqlite files (00f3faf)
  • remove upfront files to be written by miscalibrator tools (aff7f85)

PR validation:

Unit test run locally with scram b runtests_testCondToolsSiStripBuildersReaders.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36334/27079

  • This PR adds an extra 20KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2021

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondTools/SiStrip (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2021

@cmsbuild, please test

to test in a realistic IB environment

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72a8f1/20936/summary.html
COMMIT: aff7f85
CMSSW: CMSSW_12_2_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36334/20936/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3041933
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 2, 2021

+db

  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 3, 2021

+1

@cmsbuild cmsbuild merged commit aab0324 into cms-sw:master Dec 3, 2021
@mmusich mmusich deleted the fixSiStripNoisesFromDBMiscalibrator branch December 3, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants