Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10_3_X] Protect storage accounting UDP messages from NaN, and Use StatisticsSenderService for all framework files #36443

Merged
merged 11 commits into from
Dec 11, 2021
Merged

[10_3_X] Protect storage accounting UDP messages from NaN, and Use StatisticsSenderService for all framework files #36443

merged 11 commits into from
Dec 11, 2021

Commits on Dec 10, 2021

  1. Code format 

    Backport from 9fc3f03
    @makortel
    makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    061b503 View commit details
    Browse the repository at this point in the history

  2. Clang-tidy 

    Backport from f49614b
    @makortel
    makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    00d1238 View commit details
    Browse the repository at this point in the history

  3. Clang-Format 

    Backport from 08cd101
    @makortel
    makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    4fd4b5a View commit details
    Browse the repository at this point in the history

  4. Protect storage accounting UDP messages from NaN 

    NaN's were being reported from the values computed using sqrt. This most likely was from the different variables not being updated atomically together.
    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3547f16 View commit details
    Browse the repository at this point in the history

  5. Report only once when trying to open file 

    Previously, each try to open the file using a different PFN would report an open attempt for the same LFN. This meant we could have multiple opens but only one close for a given LFN.
    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    97128d9 View commit details
    Browse the repository at this point in the history

  6. StatisticsSenderService now requires LFN or URL 

    When sending information to the StatisticsSenderService, the file LFN or URL must be supplied.
    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    539b60f View commit details
    Browse the repository at this point in the history

  7. Report all framework files to StatisticsSenderService 

    Send statistics for primary, secondary, and embedded files.
The aggregate file statistics are only reset on primary file close boundaries to keep the behavior the same as previous.
Changed all calls to closeFile_() to be the new closeFile()
    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    11af972 View commit details
    Browse the repository at this point in the history

  8. Changed SecondaryProducer to be a one::EDProducer

    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ebae087 View commit details
    Browse the repository at this point in the history

  9. Added unit test for StatisticsSenderService

    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    2299c43 View commit details
    Browse the repository at this point in the history

  10. Pass InputType to StatisticsSenderService 

    Now broadcasts how the file is used.
    @Dr15Jones @makortel
    Dr15Jones authored and makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    6299e01 View commit details
    Browse the repository at this point in the history

  11. Silence file closuring printouts in StatisticsSenderService by default

    @makortel
    makortel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    24b58c9 View commit details
    Browse the repository at this point in the history