[10_2_X] Protect storage accounting UDP messages from NaN, and Use StatisticsSenderService for all framework files #36456
Conversation
Backport from 9fc3f03
Backport from f49614b
Backport from 08cd101
NaN's were being reported from the values computed using sqrt. This most likely was from the different variables not being updated atomically together.
Previously, each try to open the file using a different PFN would report an open attempt for the same LFN. This meant we could have multiple opens but only one close for a given LFN.
When sending information to the StatisticsSenderService, the file LFN or URL must be supplied.
Send statistics for primary, secondary, and embedded files. The aggregate file statistics are only reset on primary file close boundaries to keep the behavior the same as previous. Changed all calls to closeFile_() to be the new closeFile()
Now broadcasts how the file is used.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_10_2_X. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad694/21183/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
@makortel Just to make sure, I see there is warning about "Duplicate Dictionaries" which doesn't show up in other backup PRs. Can you have a look? |
|
@qliphy Thanks for catching. That warning appears to be already in the IBs https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py/slc6_amd64_gcc700/www/sun/10.2-sun-00/CMSSW_10_2_X_2021-12-12-0000/testLogs/dupDict-lostDefs.log On a quick look I wasn't able to figure out why those warnings are given in the IBs. |
|
+1 |
PR description:
This PR is a combined backport of #35362 and #35505, following requests in #29412 and #36349. It also contains small part of #26789 and #26729 to make the cherry-picks easier, and #36403 (fully) as further cleanup.
For future reference (when cherry-picking commits from #36443) the backport of #26729 conflicted with earlier backport of #28589, but the conflicts were straightforward to solve.
PR validation:
Unit tests run