New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused MASS_POINT and SLHA_FILE from Exotica_HSCP_SIM_cfi #36519
Conversation
A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild , please test |
type bug-fix |
urgent
|
(partial) backport of #28416 |
backport of #28416 |
+1 I guess it is a correct fix, so sign in advance |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d9de7/21317/summary.html Comparison SummarySummary:
|
@tvami where is the configuration SimG4Core/CustomPhysics/python/Exotica_HSCP_SIM_cfi.py used? |
@perrotta , this fragment is needed to simulate particles, which do not yet discovered. In Geant4 built in only particles, which are seen in experiments and their changes, masses and other quantum numbers are defined in PDG. For any exotica it is needed to add list of extra particles and their interaction on top of Geant4. This is supported within SimG4Core/CustomPhysics sub-library. |
Hi @perrotta most of the UL samples use GEN and SIM separately. The EXO samples have a need to do it in one GEN-SIM step, and so the use for these MASS_POINT and SLHA_FILE are restricted to this customization. Well when I say "use", it's a history use, since as you can see it's never consumed in 10_6_X anymore. |
+1
|
PR description:
Tau-prime samples dont have SLHA inputs [1], but when doing a GEN-SIM campaign the SIM part for the costumization looks for a value, that is never used after all, and so the cmsDriver command cannot be built.
[1] https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_fragment/EXO-RunIISummer20UL17GENSIM-00002
PR validation:
Running
if this PR is a backport please specify the original PR and why you need to backport that PR:
It's a partial backport of #28416