clean-up remaining commented instances of createNewIOV in the codebase

[mmusich]

PR description:

Title says it, complementary to #36490.
Even though commented, the changes would still compile if uncommented.

PR validation:

cmssw compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36532/27436

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)
• Alignment/LaserAlignment (alca)
• Alignment/TrackerAlignment (alca)
• CondTools/SiStrip (db)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @tocheng, @VinInn, @tlampen, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

(even if there's nothing to test)

[tvami]

Hi @mmusich thanks for doing this. May I ask what use-case do you see with having these commented out lines in CMSSW? Why not just remove them fully? Thanks for the explanation!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c32fb/21354/summary.html
COMMIT: 4b5b3b4
CMSSW: CMSSW_12_3_X_2021-12-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36532/21354/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11392 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250719
• DQMHistoTests: Total failures: 13212
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3237485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: found differences in 4 / 41 workflows

[tvami]

+1

• with the comment that in a future cleanup these could even be fully removed
• tests show lot of diffs that are not coming from this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• I agree that if not needed these commented out lines should be better fully removed. In any case, at least now the code should technically work even if uncommented