Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex104 Modify xml files for plt, bcmf to be included for run3 scenario and test how removal of bsc detector from the scenario can be made effective #36564

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 21, 2021

PR description:

Check possibility of adding plt, bcmf and remove bsc detector for run3 scenario. PLT, BCM, BHM detectors should be a part of the Run3 scenario and BSC has been decommissioned after Run1. The RUn3 scenario needs changes. The xml files for PLT, BCM need some changes to be included in the Run3 scenario. Before modifying the Run3 scenario, the changes needed in these XML files are tested with overlap checks. These changes along with the demonstration chambers for GE21 and RPC will be included in the new Run3 geometry description.

PR validation:

Checked with the overlap checking tool within Geometry/MuonCommonData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special. Once integrated will redefine Run3 geometry

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36564/27508

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/ForwardCommonData (geometry)
  • Geometry/MuonCommonData (geometry)
  • Geometry/TrackerCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @JanFSchulte, @VinInn, @ptcox, @mmusich, @ghugo83, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebbe09/21418/summary.html
COMMIT: 87d8b50
CMSSW: CMSSW_12_3_X_2021-12-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36564/21418/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461688
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461666
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

@cvuosalo Once this PR and #36551 are integrated I can define the new Run3 geometry scenario with changes in production cuts for muon, demonstration chambers for GE21, RPC and modified BRIL detectors

@civanch
Copy link
Contributor

civanch commented Dec 22, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@bsunanda could you please make both the title and the PR description more self-explanatory?
What do you mean by "Check possibility of adding plt, bcmf and remove bsc detector for run3 scenario"?
Are you adding in Geometry the configurations that allow you doing those checks, or what? Are you using the IBs for those checks (not optimal, if so)?

@bsunanda bsunanda changed the title Run3-gex104 Check possibility of adding plt, bcmf and remove bsc detector for run3 scenario Run3-gex104 Modify xml files for plt, bcmf to be included for run3 scenario and test how removal of bsc detector from the scenario can be made effective Dec 22, 2021
@bsunanda
Copy link
Contributor Author

@perrotta @qliphy I changed the title and PR description. The next step will be modification of Run3 geometry definition. This was discussed in the last SIM meeting on December 17

@perrotta
Copy link
Contributor

@perrotta @qliphy I changed the title and PR description. The next step will be modification of Run3 geometry definition. This was discussed in the last SIM meeting on December 17

Thank you Sunanda!

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3428e37 into cms-sw:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants