Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PF HLT Calibration and new EGM Regression in mcRun3 and mcRun4 GTs #36710

Merged

Conversation

malbouis
Copy link
Contributor

PR description:

This PR is to include in the mcRun3 and mcRun4 GTs the PF calibration HLT tag as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4572.html and new EGM Regression as requested in https://cms-talk.web.cern.ch/t/mc-update-of-new-egm-regression-conditions/4637 .

The PF tag is PFCalibration_120X_mcRun3_2021_hlt.

For EGM, there 24 tags, listed below:
electron_eb_ecalTrk_1To500_0p2To2_mean_Run3_120X_V1
electron_ee_ecalTrk_1To500_0p2To2_mean_Run3_120X_V1
electron_eb_ecalTrk_1To500_0p0002To0p5_sigma_Run3_120X_V1
electron_ee_ecalTrk_1To500_0p0002To0p5_sigma_Run3_120X_V1
photon_eb_ecalOnly_5To500_0p2To2_mean_Run3_120X_V1
photon_ee_ecalOnly_5To500_0p2To2_mean_Run3_120X_V1
photon_eb_ecalOnly_5To500_0p0002To0p5_sigma_Run3_120X_V1
photon_ee_ecalOnly_5To500_0p0002To0p5_sigma_Run3_120X_V1
electron_eb_ecalOnly_1To500_0p2To2_mean_Run3_120X_V1
electron_ee_ecalOnly_1To500_0p2To2_mean_Run3_120X_V1
electron_eb_ecalOnly_1To500_0p0002To0p5_sigma_Run3_120X_V1
electron_ee_ecalOnly_1To500_0p0002To0p5_sigma_Run3_120X_V1
pfscecal_EBCorrection_offline_v2_Run3_120X_V1
pfscecal_EECorrection_offline_v2_Run3_120X_V1
pfscecal_EBUncertainty_offline_v2_Run3_120X_V1
pfscecal_EEUncertainty_offline_v2_Run3_120X_V1
GEDelectron_EBCorrection_120X_EGM_v1
GEDelectron_EBUncertainty_120X_EGM_v1
GEDelectron_EECorrection_120X_EGM_v1
GEDelectron_EEUncertainty_120X_EGM_v1
GEDphoton_EBCorrection_120X_EGM_v1
GEDphoton_EBUncertainty_120X_EGM_v1
GEDphoton_EECorrection_120X_EGM_v1
GEDphoton_EEUncertainty_120X_EGM_v1

The GT diff wrt the previous ones in autoCond are:

phase1_2021_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021_design_v3/123X_mcRun3_2021_design_v2

phase1_2021_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021_realistic_v3/123X_mcRun3_2021_realistic_v2

phase1_2021_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021cosmics_realistic_deco_v3/123X_mcRun3_2021cosmics_realistic_deco_v2

phase1_2021_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2021_realistic_HI_v3/123X_mcRun3_2021_realistic_HI_v2

phase1_2023_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2023_realistic_v3/123X_mcRun3_2023_realistic_v2

phase1_2024_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun3_2024_realistic_v3/123X_mcRun3_2024_realistic_v2

phase2_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mcRun4_realistic_v3/123X_mcRun4_realistic_v2

PR validation:

runTheMatrix -l 12034.0,7.23,12834.0 --ibeos -j16

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36710/27792

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

test parameters:

  • workflows=12034.0,7.23,12834.0

@malbouis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-469a2e/21729/summary.html
COMMIT: ee4b4ca
CMSSW: CMSSW_12_3_X_2022-01-14-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36710/21729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-469a2e/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-469a2e/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 15217 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 14637
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3446999
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 6 / 42 workflows

@francescobrivio
Copy link
Contributor

+alca

  • differences in the tests are due to the changes in the GTs and are visible in Run3/Run4 MC wfs as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 17, 2022

+1

@cmsbuild cmsbuild merged commit 590fce2 into cms-sw:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants