Fix memory leak in PFRecHitCaloNavigator*

[lgray]

Multiple times per-event memory leak in PFRecHitCaloNavigator from respawning owned topology class.
Fixed with unique_ptr and ownership flag.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_1_X.

Fix memory leak in PFRecHitCaloNavigator*

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
I found an error when building:

/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lRecoMETMETAlgorithms
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lRecoEcalEgammaCoreTools
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lGeometryEcalAlgo
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCondCoreDBOutputService
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lCondCoreCondDB
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc481/src/RecoParticleFlow/PFClusterProducer/src/RecoParticleFlowPFClusterProducer/libRecoParticleFlowPFClusterProducer.so] Error 1
gmake: **\* Waiting for unfinished jobs....
--- Registered EDM Plugin: PFClusterAnalyzer
--- Registered EDM Plugin: PFClusterComparator
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3676/1277/summary.html

[lgray]

@cmsbuild looks like something screwed up in the IB? Retest when possible?

[anton-a]

+1
tested on wf202 with CMSSW_7_1_X_2014-05-07-1400

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

-1
When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3676/1333/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3676/1333/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[ktf]

The issue seems to be a DAS glitch. Can you rerun, please?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3676/15/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3676/15/summary.html