Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change weight file names #3678

Closed

Conversation

dbenedet
Copy link
Contributor

@dbenedet dbenedet commented May 5, 2014

New weight files for the trackerDriven seeding need to be uploaded.
They are 9 xml files. Could you also take care of the request in cmsdist?

The branch with all the code changes will come tomorrow.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2014

A new Pull Request was created by @dbenedet for CMSSW_7_1_X.

change weight file names

It involves the following packages:

RecoParticleFlow/PFTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 5, 2014

Hi Daniele,

What's the effect of these new weight files?

The download.url is not really used anymore.
So, this PR is not needed for the release.
It is, however useful to know that there is an update.

Giulio, how should we handle these? (is attention of the release managers enough in this case)

@dbenedet
Copy link
Contributor Author

dbenedet commented May 5, 2014

Is updating the trackerDriven seeding after 5 years :) ... the effect are reported on Sachiko talk. A bit more efficiency for the same fake rate:
https://indico.cern.ch/event/305108/contribution/1/material/slides/0.pdf

I tested in pre6 and I confirmed the results. Unfortunately there were many changes on GoodSeedProducer for pre7 so when rebasing I needed to solve quite many conflict. I am re-checking the results now.

@slava77
Copy link
Contributor

slava77 commented May 5, 2014

Hi Daniele,

Thank you for the summary of the effects.
It helps a lot to document the release changes with some details in one place.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2014

@slava77
Copy link
Contributor

slava77 commented May 9, 2014

+1

this PR is pointless though. The download.url files are not used anymore

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented May 10, 2014

Indeed. @Degano did you take care of the external package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants