Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex108XD Modify muon numbering, adding scenarios for the corretced Run3 geometry in CMSSW version 12_2_X #36782

Merged
merged 3 commits into from Feb 7, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jan 23, 2022

PR description:

Modify muon numbering, adding scenarios for the corretced Run3 geometry. Backport the 2 PR's #36654, #36679. Need a fresh PR for GT to make it work

PR validation:

To be tested with the PR's #36740, #36780, #36781 and #36785

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backporting the PR's already in the master to make the correct Run3 geometry scenario

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_2_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/MuonNumbering (geometry)

@malbouis, @civanch, @yuanchao, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @tocheng, @ptcox, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

-1

@bsunanda I don't think copy-pasting 12_3_X GTs in 12_2_X is the correct way to go.
If the new geometry tags for 12_2_X are available, please @cms-sw/geometry-l2 let us know and we will create the 12_2_X Run3 MC GTs that contain the updated geometry.

@bsunanda bsunanda changed the title Run3-gex108XD Modify muon numbering, adding scenarios and GT for the corretced Run3 geometry Run3-gex108XD Modify muon numbering, adding scenarios for the corretced Run3 geometry Jan 23, 2022
@cmsbuild
Copy link
Contributor

Pull request #36782 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

Hi @bsunanda please include [12_2_X] in the PR title, thanks!

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

backport of #36654

@tvami
Copy link
Contributor

tvami commented Jan 23, 2022

backport of #36679

@francescobrivio
Copy link
Contributor

@cmsbuild please test with #36740,#36780,#36781,#36785

@bsunanda bsunanda changed the title Run3-gex108XD Modify muon numbering, adding scenarios for the corretced Run3 geometry Run3-gex108XD Modify muon numbering, adding scenarios for the corretced Run3 geometry in CMSSW version 12_2_X Jan 23, 2022
@bsunanda
Copy link
Contributor Author

@tvami I have made the changes as suggested by you

@perrotta
Copy link
Contributor

Backport of #36654, #36679
(please check, and update the PR description with it)

@cmsbuild
Copy link
Contributor

Pull request #36782 was updated. @perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Jan 29, 2022

@cvuosalo , @srimanob, is this PR OK?

@qliphy
Copy link
Contributor

qliphy commented Jan 31, 2022

please test with #36740,#36780,#36781,#36785

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f1617/22093/summary.html
COMMIT: 7508361
CMSSW: CMSSW_12_2_X_2022-01-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36782/22093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16673 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 37477
  • DQMHistoTests: Total nulls: 24
  • DQMHistoTests: Total successes: 3213071
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1619.086 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 131.874 KiB RPC/AllHits
  • DQMHistoSizes: changed ( 11634.0,... ): 131.728 KiB RPC/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 0.078 KiB RPC/RPCRecHitV
  • DQMHistoSizes: changed ( 11634.911 ): 33.682 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 11634.911 ): 1.448 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.911 ): 0.614 KiB GEM/SimHits
  • DQMHistoSizes: changed ( 11634.911 ): 0.531 KiB GEM/Pad
  • DQMHistoSizes: changed ( 11634.911 ): 0.432 KiB GEM/PadCluster
  • DQMHistoSizes: changed ( 11634.911 ): 0.299 KiB GEM/RecHits
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 5 / 41 workflows

@srimanob
Copy link
Contributor

srimanob commented Feb 1, 2022

+Upgrade

For the upgrade side, checking on dict2021 shows identical with master. The backport looks OK and changes are as expected as in the master #36679 for Run-3.

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 2, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2022

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2022

+1

@cmsbuild cmsbuild merged commit 66b8f79 into cms-sw:CMSSW_12_2_X Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants