New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add muon shower plots to uGMT online DQM #36920
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36920/28232
|
A new Pull Request was created by @dinyar (Dinyar Rabady) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...Comparison SummarySummary:
|
Looks like the failed tests are all due to input files not being found. I checked the DQM bin by bin results and those looks consistent with the aim of this PR. The new plots appear for some workflows (should be all Run3 workflows). They aren't filled, but I assume this is due to the datasets in question as I did see them being filled when running locally. |
Hi @dinyar |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
This PR adds DQM plots for the new hadronic showers at the uGMT input and output. They are gated behind flags only set true for the Run3 era.
PR validation:
Used a private RAW file to check if the plots appear in the DQM. Also checked that they aren't created when not run under the Run3 era.