Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muon shower plots to uGMT online DQM #36920

Merged
merged 1 commit into from Feb 10, 2022

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Feb 9, 2022

PR description:

This PR adds DQM plots for the new hadronic showers at the uGMT input and output. They are gated behind flags only set true for the Run3 era.

PR validation:

Used a private RAW file to check if the plots appear in the DQM. Also checked that they aren't created when not run under the Run3 era.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36920/28232

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2022

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1fb17/22312/summary.html
COMMIT: 92f660d
CMSSW: CMSSW_12_3_X_2022-02-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36920/22312/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250202.5250202.5_TTbar_13+TTbar_13INPUT+PREMIXUP15_PU25+DIGIPRMXLOCALUP15APVSimu_PU25+RECOPRMXUP15_HIPM_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13INPUT+PREMIXUP15_PU25+DIGIPRMXLOCALUP15APVSimu_PU25+RECOPRMXUP15_HIPM_PU25+HARVESTUP15_PU25.log
  • 250202.3250202.3_TTbar_13+TTbar_13INPUT+PREMIXUP15_PU25+DIGIPRMXLOCALUP15APVSimu_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13INPUT+PREMIXUP15_PU25+DIGIPRMXLOCALUP15APVSimu_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25.log
  • 250202.2250202.2_TTbar_13+TTbar_13INPUT+DIGIPRMXUP15APVSimu_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13INPUT+DIGIPRMXUP15APVSimu_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765080
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3765050
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.185 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.261 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 0.194 KiB L1TEMU/L1TdeStage2uGMT
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@dinyar
Copy link
Contributor Author

dinyar commented Feb 10, 2022

Looks like the failed tests are all due to input files not being found.

I checked the DQM bin by bin results and those looks consistent with the aim of this PR. The new plots appear for some workflows (should be all Run3 workflows). They aren't filled, but I assume this is due to the datasets in question as I did see them being filled when running locally.

@jfernan2
Copy link
Contributor

Hi @dinyar
The Run3 datasets are all TTbar, but with 10 events for these tests, so most likely not many muons inside to fill your new plots.
If you have tested they are filled sucessfully in private tests, then it should be OK

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c886cf8 into cms-sw:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants