Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[122X] L1T: remove l1ExtraParticles from stage 2 reco and its consuption in DQM #36930

Merged
merged 1 commit into from Feb 11, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Feb 10, 2022

PR description:

Please see #36916

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #36916

Resolves #36806

@tvami
Copy link
Contributor Author

tvami commented Feb 10, 2022

backport of #36916

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 10, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_2_X.

It involves the following packages:

  • HLTriggerOffline/Exotica (dqm)
  • L1Trigger/Configuration (l1)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mtosi this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Feb 10, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fd947/22343/summary.html
COMMIT: da8862c
CMSSW: CMSSW_12_2_X_2022-02-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36930/22343/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3251259
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -14.417 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 10024.0,... ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 11634.0,... ): -2.845 KiB HLT/Exotica
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 2 / 41 workflows

@tvami
Copy link
Contributor Author

tvami commented Feb 11, 2022

Hi @jfernan2 @cecilecaillol please sign the backport as well, thanks!

@qliphy
Copy link
Contributor

qliphy commented Feb 11, 2022

urgent

@cecilecaillol
Copy link
Contributor

+l1

@francescobrivio
Copy link
Contributor

@cms-sw/dqm-l2 please have a look at this as soon as possible so we can merge it and build the new 12_2_X release.

@jfernan2
Copy link
Contributor

+1
This PR removes 10 MEs from HLT/Exotica folder

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit df06cdd into cms-sw:CMSSW_12_2_X Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants