-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead branches and clean up GlobalRecHit validation #36949
Remove dead branches and clean up GlobalRecHit validation #36949
Conversation
} | ||
|
||
edm::Handle<RPCRecHitCollection> recHit; | ||
iEvent.getByToken(MuRPCSrc_Token_, recHit); | ||
bool validrpc = true; | ||
if (!simHit.isValid()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the bug...
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36949/28300
|
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c81a79/22389/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Some unused chunk of code was removed, starting from some issue reported by the static analyzer (having lot of those unsolved issues can hide the real one, if they show up: better to clean up when possible).
While doing so a bug was also found and fixed (harmless as soon as all collections to be validated are available)
PR validation:
It compiles.
There should be no differences at all in outputs