[12.2.X] Fix BeamSpotAnalyzer::fillDescriptions

[mmusich]

backport of #37085

PR description:

As reported by @francescobrivio, PR #35236 introduced a wrong type for the parameter BSAnalyzerParameters (which should be a PSet and non a VPSet).
This is fixed in this PR, together with completing the rest of descriptions coming from the BeamFitter and PVFitter classes.
I profit of this PR to introduce a unit test to check the functionality of the analyzer.

PR validation:

Relies on the unit tests provided in this PR

if this PR is a backport please specify the original PR and why you need to backport that PR:

Verbatim backport of #37085, if we ever need to re-derive a BeamSpot of the 12.2.X 900GeV data and/or MC.

[mmusich]

type bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix BeamSpotAnalyzer::fillDescriptions #37085

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad0d5d/22737/summary.html
COMMIT: 285031c
CMSSW: CMSSW_12_2_X_2022-03-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37099/22737/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251294
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3251266
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• direct backport of Fix BeamSpotAnalyzer::fillDescriptions #37085
• no changes, technical, needed for datataking (AFAIK)

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1