Run3-hcx330 Cleanup some of the codes in Validation/HcalHits #37165

bsunanda · 2022-03-08T07:14:04Z

PR description:

Cleanup some of the codes in Validation/HcalHits

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2022-03-08T07:23:00Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28730

This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28730/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28730/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-03-08T07:50:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28732

This PR adds an extra 52KB to repository

cmsbuild · 2022-03-08T07:51:06Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Validation/HcalHits (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@abdoulline, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-03-08T07:58:59Z

@cmsbuild please test

cmsbuild · 2022-03-08T09:25:48Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dd136/22925/summary.html
COMMIT: 0e36f1e
CMSSW: CMSSW_12_3_X_2022-03-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37165/22925/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 08-Mar-2022 09:16:13 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module HcalSimHitsValidation/'HcalSimHitsAnalyser'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<PCaloHit>
Looking for module label: @EmptyLabel@
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 08-Mar-2022 09:16:14 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module HcalSimHitsValidation/'HcalSimHitsAnalyser'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<PCaloHit>
Looking for module label: @EmptyLabel@
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

2018.1

----- Begin Fatal Exception 08-Mar-2022 09:21:44 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module HcalSimHitsValidation/'HcalSimHitsAnalyser'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<PCaloHit>
Looking for module label: @EmptyLabel@
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 08-Mar-2022 09:14:26 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 1
   [1] Running path 'validation_step'
   [2] Calling method for module HcalSimHitsValidation/'HcalSimHitsAnalyser'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<PCaloHit>
Looking for module label: @EmptyLabel@
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 08-Mar-2022 09:14:26 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 2
   [1] Running path 'validation_step'
   [2] Calling method for module HcalSimHitsValidation/'HcalSimHitsAnalyser'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<PCaloHit>
Looking for module label: @EmptyLabel@
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 08-Mar-2022 09:14:25 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module HcalSimHitsValidation/'HcalSimHitsAnalyser'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<PCaloHit>
Looking for module label: @EmptyLabel@
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

cmsbuild · 2022-03-08T14:14:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28740

This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28740/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37165/28740/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-03-09T09:12:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dd136/22954/summary.html
COMMIT: 54463d8
CMSSW: CMSSW_12_3_X_2022-03-08-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37165/22954/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
Reco comparison had 17 failed jobs
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3703700
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3703667
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 0 log files, 0 edm output root files, 49 DQM output files

jfernan2 · 2022-03-09T09:20:55Z

For some reason, bin by bin tests were only run for wf 1000
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-03-08-2300+2dd136/48810/dqm-histo-comparison-summary.html
I don't see any message in log:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-03-08-2300+2dd136/48810/dqmBinByBinLog.log
Hence I would like to rerun the tests again

jfernan2 · 2022-03-09T12:18:44Z

please test

cmsbuild · 2022-03-09T16:17:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dd136/22972/summary.html
COMMIT: 54463d8
CMSSW: CMSSW_12_3_X_2022-03-08-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37165/22972/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3703700
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3703669
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 0 log files, 0 edm output root files, 49 DQM output files

jfernan2 · 2022-03-09T18:12:09Z

For some reason I don't understand, the results of this PR and #37183 do not show the bin by bin results for all WFs but 1000.0
However, since RelMon is not showing any difference I am signing the PR

jfernan2 · 2022-03-09T18:12:15Z

+1

cmsbuild · 2022-03-09T18:12:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-03-10T01:01:20Z

For some reason I don't understand, the results of this PR and #37183 do not show the bin by bin results for all WFs but 1000.0 However, since RelMon is not showing any difference I am signing the PR

@smuzaffar Do you know why this happens?

qliphy · 2022-03-10T01:43:42Z

please test

#37172 (comment)

cmsbuild · 2022-03-10T06:56:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dd136/22996/summary.html
COMMIT: 54463d8
CMSSW: CMSSW_12_3_X_2022-03-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37165/22996/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695161
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3695130
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-03-10T08:48:11Z

+1
Now the results are there, thanks @qliphy

qliphy · 2022-03-10T08:53:58Z

+1

Cleanup some of the codes in Validation/HcalHits

6c3d008

cmsbuild added this to the CMSSW_12_3_X milestone Mar 8, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Mar 8, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 8, 2022

Code check

0e36f1e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 8, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 8, 2022

cmsbuild added tests-rejected and removed tests-started labels Mar 8, 2022

Try to fix the failure

ba9f25a

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Mar 8, 2022

cmsbuild removed the code-checks-pending label Mar 8, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 9, 2022

cmsbuild added tests-started and removed tests-approved labels Mar 9, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 9, 2022

jfernan2 mentioned this pull request Mar 9, 2022

Run3-hcx331 Cleanup some of the codes in Validation/HcalRecHits #37183

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 9, 2022

cmsbuild added tests-started and removed tests-approved labels Mar 10, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Mar 10, 2022

cmsbuild merged commit e941f53 into cms-sw:master Mar 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx330 Cleanup some of the codes in Validation/HcalHits #37165

Run3-hcx330 Cleanup some of the codes in Validation/HcalHits #37165

bsunanda commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

bsunanda commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 9, 2022

jfernan2 commented Mar 9, 2022

jfernan2 commented Mar 9, 2022

cmsbuild commented Mar 9, 2022

jfernan2 commented Mar 9, 2022

jfernan2 commented Mar 9, 2022

cmsbuild commented Mar 9, 2022

qliphy commented Mar 10, 2022

qliphy commented Mar 10, 2022

cmsbuild commented Mar 10, 2022

jfernan2 commented Mar 10, 2022

qliphy commented Mar 10, 2022

Run3-hcx330 Cleanup some of the codes in Validation/HcalHits #37165

Run3-hcx330 Cleanup some of the codes in Validation/HcalHits #37165

Conversation

bsunanda commented Mar 8, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

bsunanda commented Mar 8, 2022

cmsbuild commented Mar 8, 2022

RelVals

AddOn Tests

cmsbuild commented Mar 8, 2022

cmsbuild commented Mar 9, 2022

Comparison Summary

jfernan2 commented Mar 9, 2022

jfernan2 commented Mar 9, 2022

cmsbuild commented Mar 9, 2022

Comparison Summary

jfernan2 commented Mar 9, 2022

jfernan2 commented Mar 9, 2022

cmsbuild commented Mar 9, 2022

qliphy commented Mar 10, 2022

qliphy commented Mar 10, 2022

cmsbuild commented Mar 10, 2022

Comparison Summary

jfernan2 commented Mar 10, 2022

qliphy commented Mar 10, 2022