Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex121 Take care of deprecrated codes in GeneratorInterface/EvtGenInterface #37222

Merged
merged 1 commit into from Mar 15, 2022

Conversation

bsunanda
Copy link
Contributor

PR description:

Take care of deprecrated codes in GeneratorInterface/EvtGenInterface

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37222/28824

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • GeneratorInterface/EvtGenInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda bsunanda changed the title Eun3-gex121 Take care of deprecrated codes in GeneratorInterface/EvtGenInterface Run3-gex121 Take care of deprecrated codes in GeneratorInterface/EvtGenInterface Mar 12, 2022
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@Saptaparna
Copy link
Contributor

Let me also add @colizz as a potential reviewer.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9120d/23062/summary.html
COMMIT: fee8973
CMSSW: CMSSW_12_4_X_2022-03-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37222/23062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Mar 15, 2022

The code looks ok to me, @colizz , do you agree?

@bsunanda
Copy link
Contributor Author

@SiewYan Here again use of plain EDAnalyzer is avoided,

@SiewYan
Copy link
Contributor

SiewYan commented Mar 15, 2022

+1

@bsunanda , thank you, Its look all good to me though.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c41b2bc into cms-sw:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants