Make mutable in EventSetupRecord atomic

[Dr15Jones]

The transient access bool is now atomic since multiple threads could attempt to change it.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Make mutable in EventSetupRecord atomic

It involves the following packages:

FWCore/Framework

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

-1
I found an error when building:

                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/FWCore/Framework/interface/EventSetupRecord.h:60,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/FWCore/Framework/interface/EventSetupRecordImplementation.h:26,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/CondFormats/DataRecord/interface/SiPixelFedCablingMapRcd.h:5,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/CondFormats/SiPixelObjects/interface/SiPixelQuality.h:17,
                 from src/CondFormats/SiPixelObjects/src/classes.h:14:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../include/c++/4.8.1/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/FWCore/Services/src/PrintLoadingPlugins.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/FWCore/Services/src/ProcInfoFetcher.cc 
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../include/c++/4.8.1/atomic:41,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/FWCore/Framework/interface/EventSetupRecord.h:60,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc5_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/FWCore/Framework/interface/EventSetupRecordImplementation.h:26,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3725/12/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[Dr15Jones]

@nclopezo please rerun the tests

[cmsbuild]

Pull request #3725 was updated. @apfeiffer1, @diguida, @monttj, @cmsbuild, @Dr15Jones, @rcastello, @ggovi, @vadler, @Degano, @ktf, @nclopezo can you please check and sign again.

[vadler]

+1
AT only minimally affected.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3725/1387/summary.html

[diguida]

+1

[apfeiffer1]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?