Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic improvement in printout of Payload Inspector plots for DropBoxMetaData #37288

Merged
merged 1 commit into from Mar 22, 2022

Conversation

tlampen
Copy link
Contributor

@tlampen tlampen commented Mar 21, 2022

PR description:

As continuation to PR #37011, improve legibility of printouts by adding a newline in front of new tag ("inputTag").

PR validation:

The correct behaviour is illustrated with the attached plots produced with a modified version of the script test/test_DropBoxMetadata_PayloadInspector.sh (plots with and without these modifications).

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A
DropBoxMetadata_Display_new
DropBoxMetadata_Display_old

@tlampen
Copy link
Contributor Author

tlampen commented Mar 21, 2022

attn: @mmusich

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37288/28919

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tlampen (Tapio Lampén) for master.

It involves the following packages:

  • CondCore/PhysicsToolsPlugins (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

@tlampen based on the screenshots you attached: I see that in the first one (that should be the new one) there is a new line before "inputTag" in the "PREP" section, but not in the "PROD" section, is this expected?

@tlampen
Copy link
Contributor Author

tlampen commented Mar 21, 2022

@tlampen based on the screenshots you attached: I see that in the first one (that should be the new one) there is a new line before "inputTag" in the "PREP" section, but not in the "PROD" section, is this expected?

Good catch. I'll fix this. Thanks!

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37288/28920

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37288 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9046a/23255/summary.html
COMMIT: b472fa8
CMSSW: CMSSW_12_4_X_2022-03-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37288/23255/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f9046a/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695650
  • DQMHistoTests: Total failures: 51181
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 3644383
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants