Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLT75e33 step to Phase-2 workflows #37324

Merged
merged 4 commits into from Apr 20, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 23, 2022

PR description:

This PR is to add Phase2 HLT75e33 to Phase-2 workflow. It needs #37162.

PR validation:

Output from the following runTheMatrix works,
runTheMatrix.py --what upgrade -l 39434.75 -t 8 --wm init

if this PR is a backport please specify the original PR and why you need to backport that PR:

After agree on the way to implement, we will need to backport to 12_3_X

@srimanob
Copy link
Contributor Author

code-checks

@srimanob
Copy link
Contributor Author

@smuzaffar Do I miss any change to make the code-check for PR test happen? Thanks.

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 23, 2022

no you did not miss any change. github itself is going through a bad time ( https://www.githubstatus.com/ ) that is why bot is not reacting to and command

@smuzaffar
Copy link
Contributor

looks like github is coming back , bot has started the code checks now

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37324/28968

@srimanob
Copy link
Contributor Author

test parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6ae7d/23329/summary.html
COMMIT: 9be8443
CMSSW: CMSSW_12_4_X_2022-03-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37324/23329/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f6ae7d/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3164700
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3164675
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 183 log files, 40 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Mar 23, 2022

This is a side note to @cms-sw/pdmv-l2 that they will face a space increasing for D88 if run with cmsDriver after this PR is merge. Duplication of FEVTDEBUGHLT content after RECO will happen. One can remove the original production of FEVT from RECO step to save relvals space.

@kskovpen
Copy link
Contributor

Thanks @srimanob . Do you have an estimate of how much it will increase in size without manual intervention in the wf configuration?

@srimanob
Copy link
Contributor Author

You will need roughly 20 TB more per standard set of D88 NoPU+PU200. I estimate from TTbar/SUSY which needs ~1TB for GEN-SIM-RECO in both PU scenario. The output from HLT step will completely overlap with RECO with additional information of HLTX step. I assume you have the drop function in RelVals machine.

Note that, I plan to make a little update on datatier. So that we will have the same GEN-SIM-RECO for output from HLTX step, and output from RECO which will be dropped can be something else, i.e. FEVT. So, this will be transparent from user point of view.

@cmsbuild
Copy link
Contributor

Pull request #37324 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6ae7d/23829/summary.html
COMMIT: b943152
CMSSW: CMSSW_12_4_X_2022-04-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37324/23829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f6ae7d/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593009
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

+Upgrade

This PR is to add workflow for HLT Phase-2. The needed PR is fully sign, #37162

@srimanob
Copy link
Contributor Author

@cms-sw/pdmv-l2 Could you please check and sign again?

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants