Cell XY to UV conversion fo HGCal wafers #37361

Pruthvi-ch · 2022-03-26T15:03:51Z

PR description:

There will no changes in the output.
No dependencies
This is related to getting cell id (u, v) form the (x, y) position inside a wafer. https://indico.cern.ch/event/1136462/

PR validation:

Use runTheMatrix test workflows 'runTheMatrix.py -l limited -i all --ibeos'
Specific cfg's in Geometry/HGCalCommonData/test/python/testHGCalCellUVTester_cfg.py to test working

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing

cmsbuild · 2022-03-26T15:09:28Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37361/29014

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37361/29014/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37361/29014/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-03-26T15:18:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37361/29015

This PR adds an extra 20KB to repository

cmsbuild · 2022-03-26T15:18:53Z

A new Pull Request was created by @Pruthvi-ch for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

srimanob · 2022-03-26T15:25:21Z

@cmsbuild please test

cmsbuild · 2022-03-26T22:10:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14eaf3/23420/summary.html
COMMIT: fe80db1
CMSSW: CMSSW_12_4_X_2022-03-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37361/23420/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3483 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 49413
DQMHistoTests: Total nulls: 54
DQMHistoTests: Total successes: 3646161
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

Geometry/HGCalCommonData/interface/HGCalCellUV.h

Geometry/HGCalCommonData/src/HGCalCellUV.cc

Pruthvi-ch · 2022-03-30T07:11:33Z

There are some changed method names in PR #37374 which will affect this PR, so I will commit the changes after that PR is merged

…_to_UV

cmsbuild · 2022-04-07T20:52:36Z

Pull request #37361 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

Pruthvi-ch · 2022-04-07T20:59:22Z

@cmsbuild please test

perrotta · 2022-04-07T21:00:24Z

please test

cmsbuild · 2022-04-08T01:29:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14eaf3/23748/summary.html
COMMIT: d532590
CMSSW: CMSSW_12_4_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37361/23748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3593039
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3593015
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 45 edm output root files, 48 DQM output files
TriggerResults: no differences found

Pruthvi-ch · 2022-04-09T13:57:13Z

Any Updates?

bsunanda · 2022-04-10T01:14:58Z

@cvuosalo @srimanob Could you please sign this again?

cvuosalo · 2022-04-11T18:43:56Z

+1

srimanob · 2022-04-12T10:21:01Z

+Upgrade

cmsbuild · 2022-04-12T10:21:28Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-04-12T11:35:31Z

Geometry/HGCalCommonData/interface/HGCalCellUV.h

+  const double sqrt3By2_ = (0.5 * sqrt3_);
+  const double sin60_ = sqrt3By2_;
+  const double cos60_ = 0.5;


Another simplification could be to use everywhere in the code sin60_ instead of sqrt3By2_, since this is everywhere what it is ment to (as well as using cos60_ instead of 0.5 when it has the same meaning):

Suggested change

const double sqrt3By2_ = (0.5 * sqrt3_);

const double sin60_ = sqrt3By2_;

const double cos60_ = 0.5;

const double sin60_ = 0.5 * sqrt3_;

const double cos60_ = 0.5;

But let it for a possible further code cleaning

perrotta · 2022-04-12T11:35:54Z

+1

Cell XY to UV conversion

e575462

cmsbuild added this to the CMSSW_12_4_X milestone Mar 26, 2022

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Mar 26, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 26, 2022

Cell XY to UV conversion

fe80db1

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 26, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 26, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2022

cvuosalo reviewed Mar 28, 2022

View reviewed changes

Geometry/HGCalCommonData/interface/HGCalCellUV.h Outdated Show resolved Hide resolved

cvuosalo reviewed Mar 28, 2022

View reviewed changes

Geometry/HGCalCommonData/src/HGCalCellUV.cc Show resolved Hide resolved

cvuosalo reviewed Mar 28, 2022

View reviewed changes

Geometry/HGCalCommonData/src/HGCalCellUV.cc Outdated Show resolved Hide resolved

Pruthvi-ch added 2 commits March 31, 2022 07:42

Merge branch 'master' of https://github.com/cms-sw/cmssw into Cell_XY…

a66a795

…_to_UV

Updates for naming convention

d9a0683

cmsbuild added tests-started and removed tests-pending labels Apr 7, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 8, 2022

cmsbuild added geometry-approved and removed geometry-pending labels Apr 11, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 12, 2022

perrotta reviewed Apr 12, 2022

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Apr 12, 2022

cmsbuild merged commit 3292699 into cms-sw:master Apr 12, 2022

This was referenced Apr 12, 2022

Add import test for professor2 #37535

Merged

Test vecgeom 1.1.20 in master branch cms-sw/cmsdist#7775

Closed

Update vecgeom to 1.1.20 cms-sw/cmsdist#7735

Merged

perrotta mentioned this pull request Apr 13, 2022

Simplify usage of constants in HGCalCellUV #37546

Merged

smuzaffar mentioned this pull request Jun 7, 2022

[UBSAN][Geometry/HGCalCommonData] index out of bound #38276

Closed

srimanob mentioned this pull request Jun 13, 2022

Phase2-hgx315Y Try to fix the error reported in #38276 #38281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cell XY to UV conversion fo HGCal wafers #37361

Cell XY to UV conversion fo HGCal wafers #37361

Pruthvi-ch commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

srimanob commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

Pruthvi-ch commented Mar 30, 2022 •

edited

cmsbuild commented Apr 7, 2022

Pruthvi-ch commented Apr 7, 2022

perrotta commented Apr 7, 2022

cmsbuild commented Apr 8, 2022

Pruthvi-ch commented Apr 9, 2022

bsunanda commented Apr 10, 2022

cvuosalo commented Apr 11, 2022

srimanob commented Apr 12, 2022

cmsbuild commented Apr 12, 2022

perrotta Apr 12, 2022

perrotta commented Apr 12, 2022

Cell XY to UV conversion fo HGCal wafers #37361

Cell XY to UV conversion fo HGCal wafers #37361

Conversation

Pruthvi-ch commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

srimanob commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

Comparison Summary

Pruthvi-ch commented Mar 30, 2022 • edited

cmsbuild commented Apr 7, 2022

Pruthvi-ch commented Apr 7, 2022

perrotta commented Apr 7, 2022

cmsbuild commented Apr 8, 2022

Comparison Summary

Pruthvi-ch commented Apr 9, 2022

bsunanda commented Apr 10, 2022

cvuosalo commented Apr 11, 2022

srimanob commented Apr 12, 2022

cmsbuild commented Apr 12, 2022

perrotta Apr 12, 2022

Choose a reason for hiding this comment

perrotta commented Apr 12, 2022

Pruthvi-ch commented Mar 30, 2022 •

edited