-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1T vertex finder phase2 developments #37382
L1T vertex finder phase2 developments #37382
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37382/29033
|
A new Pull Request was created by @cecilecaillol for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37382/29035
|
Pull request #37382 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again. |
please test |
please test |
if (maximum <= minimum) { | ||
maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05; | ||
minimum = float(*std::min_element(std::begin(data), std::end(data))); | ||
} | ||
|
||
if (minimum < 0) { | ||
minimum *= 1.05; | ||
} else { | ||
minimum = 0; | ||
} | ||
|
||
if (maximum == -1) { | ||
maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Cecile for taking my comments into account.
However, your update won't deal correctly with the case when maximum = -1
(and minimun is above it) from the parameter set.
A possible suggestion could be:
if (maximum <= minimum) { | |
maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05; | |
minimum = float(*std::min_element(std::begin(data), std::end(data))); | |
} | |
if (minimum < 0) { | |
minimum *= 1.05; | |
} else { | |
minimum = 0; | |
} | |
if (maximum == -1) { | |
maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05; | |
} | |
if (maximum == -1) { | |
maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05; | |
} | |
else if (maximum <= minimum) { | |
maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05; | |
minimum = float(*std::min_element(std::begin(data), std::end(data))); | |
} | |
if (minimum < 0) { | |
minimum *= 1.05; | |
} else { | |
minimum = 0; | |
} |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37382/29120
|
Pull request #37382 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d36cf/23590/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is another PR to port all L1T Phase-2 developments to cms-sw. This PR targets the vertex finder code. It includes several PRs made locally, the details of which can be found in the twiki https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideL1TPhase2Instructions and in the cms-l1t-offline branch.