ECAL GPU unpacker - Add detection of corrupted DCC tower headers and recovery - backport 12_3_X

[thomreis]

PR description:

Backport of #37430

Up to now the ECAL GPU unpacker did not check the DCC tower headers consistency when using it. A corrupted header with tower block length extracted as 0 leads to an infinite loop.

This PR fixes this by first building a list of FE channels that are expected to contain data and checking the TT id extracted from the tower header against it. In case of a mismatch the tower block is skipped and the next good tower header is searched in the raw data. The unpacking then continues with the tower block with the next good header.

This PR fixes #37323.

PR validation:

No infinite loop anymore with the configuration and data described in #37323.

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_12_3_X.

It involves the following packages:

• EventFilter/EcalRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @Martin-Grunewald, @missirol, @thomreis, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from ECAL GPU unpacker - Add detection of corrupted DCC tower headers and recovery #37430

[thomreis]

Backport of #37430

[thomreis]

type bugfix

[jpata]

enable gpu

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbe6c8/23616/summary.html
COMMIT: e0853b1
CMSSW: CMSSW_12_3_X_2022-04-01-2300/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37435/23616/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19874
• DQMHistoTests: Total failures: 1597
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18277
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697345
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• an exact backport of ECAL GPU unpacker - Add detection of corrupted DCC tower headers and recovery #37430, needed for datataking
• no relevant reco changes
• I didn't check explicitly that the bug was fixed also in the backport, relying on the tests done in the original PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of ECAL GPU unpacker - Add detection of corrupted DCC tower headers and recovery #37430