Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update final L1T menu tag for Run 3 start up #37442

Merged
merged 1 commit into from Apr 3, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR updates the final L1T menu tag for Run 3 start up, as requested in this CMSTalk post, for Run3 MC GTs and the Run3 relval GTs used for TSG tests.
The new L1T tag is L1Menu_Collisions2022_v1_0_0_xml.

GT differences:

Run 3 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_relval_v2/123X_dataRun3_HLT_relval_v3

Run 3 data RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_relval_v2/123X_dataRun3_relval_v3

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_design_v12/123X_mcRun3_2021_design_v13

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_realistic_v12/123X_mcRun3_2021_realistic_v13

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021cosmics_realistic_deco_v12/123X_mcRun3_2021cosmics_realistic_deco_v13

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_realistic_HI_v12/123X_mcRun3_2021_realistic_HI_v13

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2023_realistic_v12/123X_mcRun3_2023_realistic_v13

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2024_realistic_v12/123X_mcRun3_2024_realistic_v13

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun4_realistic_v9/123X_mcRun4_realistic_v10

PR validation:

Tested with:
runTheMatrix.py -l 12034.0,11634.0,7.23,159.0,12434.0,12834.0 --ibeos -j16

Backport:

Not a backport, but a backport to 12_3_X will be provided soon.

FYI @elfontan @Martin-Grunewald

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows=12034.0,7.23,159.0,12834.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37442/29138

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2022

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-688758/23620/summary.html
COMMIT: 981a911
CMSSW: CMSSW_12_4_X_2022-04-01-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37442/23620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-688758/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-688758/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 160 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4068531
  • DQMHistoTests: Total failures: 1346
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4067162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 219 log files, 45 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 2, 2022

Hmm the results seem interesting, in data where the new GT is used, there are differences in the tracking, see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_4_X_2022-04-01-2300+688758/49366/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB/

but the MCs that used the same new tag have no difference. Can @elfontan @silviodonato comment on this? Thanks

@francescobrivio
Copy link
Contributor Author

Hmm the results seem interesting, in data where the new GT is used, there are differences in the tracking, see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_4_X_2022-04-01-2300+688758/49366/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB/

but the MCs that used the same new tag have no difference. Can @elfontan @silviodonato comment on this? Thanks

Pinging also @Martin-Grunewald and @missirol who I know are involved in this development as well.

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Apr 2, 2022

Hmm the results seem interesting, in data where the new GT is used, there are differences in the tracking, see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_4_X_2022-04-01-2300+688758/49366/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB/
but the MCs that used the same new tag have no difference. Can @elfontan @silviodonato comment on this? Thanks

Do you know what are these IOV differences? image

The difference is in the workflow based on the 2021 minbias data (pilot beam test)

Hi Silvio! The differences are due to "live" tags that got updated in the meanwhile (by O2Os or manually by users), but 139.001 is running on run 346512, so all these differences should be irrelevant.

@silviodonato
Copy link
Contributor

no idea... I'd suggest to run the tests one more time to confirm that the differences are real

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Apr 2, 2022

no idea... I'd suggest to run the tests one more time to confirm that the differences are real

Before restarting the tests I'd like to see if there are other suggestions, because the backport PR (#37443 (comment)) tests are showing very similar results...

@mmusich
Copy link
Contributor

mmusich commented Apr 2, 2022

@francescobrivio,

Hi Silvio! The differences are due to "live" tags that got updated in the meanwhile (by O2Os or manually by users), but 139.001 is running on run 346512, so all these differences should be irrelevant.

They are very relevant instead. By updating the snapshot of the data GT you have unlocked this new IOV:

Screenshot from 2022-04-02 17-08-49

which was announced here: https://cms-talk.web.cern.ch/t/offline-gt-updating-corrected-fixed-pixel-cpe-2d-template/8734/1
This is expected to make small, but visible changes in tracking.

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Apr 2, 2022

Hi @mmusich, indeed you are right, I had missed that IOV difference. Thanks a lot!

@tvami
Copy link
Contributor

tvami commented Apr 2, 2022

+alca

  • diffs in tracking are coming from the change of snapshot time
  • otherwise no other diffs are seen

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 3, 2022

+1

@cmsbuild cmsbuild merged commit a3bd9c2 into cms-sw:master Apr 3, 2022
@francescobrivio francescobrivio deleted the alca-updateL1Tmenu branch April 6, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants