Customize for OT inefficiency

[mmusich]

PR description:

This is a first follow-up to PR #37397.
It consists of two commits:

• 1c79266 simplifies the logic in SiPhase2BadStripChannelBuilder as requested at introduce SiPhase2BadStrip format for phase-2 simulation #37397 (comment)
• 4c880ce add file with customization functions for OT Inefficiencies, with different choices for the random fraction of bad strips

PR validation:

Tested e.g. with:

runTheMatrix.py -l 35434.0 --command='--customise SimTracker/SiPhase2Digitizer/customizeForOTInefficiency.customizeSiPhase2OTInefficiencyOnePercent'

and checked that the right switches get activated.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cc:
@suchandradutta @emiglior

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37463/29160

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/SiPhase2Tracker (upgrade, alca)
• SimTracker/SiPhase2Digitizer (upgrade, simulation)

@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37463/29161

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #37463 was updated. @malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @tvami, @francescobrivio can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b25d43/23656/summary.html
COMMIT: 17f5d9b
CMSSW: CMSSW_12_4_X_2022-04-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37463/23656/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593009
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[civanch]

+1

[srimanob]

+Upgrade

This PR include the simplified coding as requested and customizations for OT Inefficiencies. No change is expected from this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

Hi @mmusich would you be available to present about this in the AlCa meeting in the coming AlCaDB meeting (Apr 11)?

[mmusich]

would you be available to present about this in the AlCa meeting in the coming AlCaDB meeting (Apr 11)?

yes, but there won't be much to discuss. 5 minutes should be sufficient.

[tvami]

would you be available to present about this in the AlCa meeting in the coming AlCaDB meeting (Apr 11)?

yes, but there won't be much to discuss. 5 minutes should be sufficient.

Thanks, here is the slot in the agenda: https://indico.cern.ch/event/1149147/#23-phase-2-outer-tracker-ineff

[qliphy]

+1