Introduce PtMaxTrackCountFilter

[mmusich]

PR description:

To study cosmic commissioning events (especially to check detector noise), it is sometimes convenient to isolate low pT tracks.
As far as I could see, there's no such filter to retain only events with at least a track below a certain threshold. This is added here.
In addition I profit to fix the fillDescriptions method of PtMinTrackCountFilter.cc which has been introduced in PR #29604 (this is done in commit: a3e1078, without it, using the filter results in failure validating the configuration).

PR validation:

Private, tested adding:

from CommonTools.RecoAlgos.ptMaxTrackCountFilter_cfi import ptMaxTrackCountFilter
process.myfilter = ptMaxTrackCountFilter.clone(src = cms.InputTag('ctfWithMaterialTracksP5'),
                                               ptMax = cms.double(3.))

to configuration file and tested it works correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37500/29202

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37500/29202/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37500/29202/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37500/29203

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CommonTools/RecoAlgos (reconstruction)
• CommonTools/UtilAlgos (reconstruction)
• CommonTools/Utils (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @abbiendi, @jhgoh, @jdolen, @gkasieczka, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c26816/23746/summary.html
COMMIT: 025780f
CMSSW: CMSSW_12_4_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37500/23746/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3593003
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

Hi @clacaputo, can you clarify what's holding this PR? shall unit tests be implemented here directly as a conditio sine qua non for accepting it?

[clacaputo]

Hi @mmusich,

study cosmic commissioning events (especially to check detector noise), it is sometimes convenient to isolate low pT tracks

if this is critical and it's needed by the next release, we can merge the PR as it is and have the unit test in a subsequent one.
Otherwise, I would prefer to have the unit test as a part of this PR.

[mmusich]

we can merge the PR as it is and have the unit test in a subsequent one.

Since I would push the changes exercising the new module in a different package, together with other changes (not under reco signature) I would prefer to keep it separate, unless there's a strong push (to get you an idea of where it would be used you can look here).

[clacaputo]

+reconstruction

• PtMaxTrackCountFilter introduced for studying cosmic commissioning data
• no reco changes expected or observed
• Unit test using the filter will be added in another PR (Introduce PtMaxTrackCountFilter #37500 (comment))

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

please test
just to refresh

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c26816/23934/summary.html
COMMIT: 025780f
CMSSW: CMSSW_12_4_X_2022-04-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37500/23934/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593003
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[qliphy]

+1

[mmusich]

Unit test using the filter will be added in another PR (#37500 (comment))

for the record, here it is: #37621